From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C29A4C00144 for ; Mon, 1 Aug 2022 11:09:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231338AbiHALJL (ORCPT ); Mon, 1 Aug 2022 07:09:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229945AbiHALJI (ORCPT ); Mon, 1 Aug 2022 07:09:08 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97B7525EB9 for ; Mon, 1 Aug 2022 04:09:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 526B8B80F9C for ; Mon, 1 Aug 2022 11:09:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8994C433D6; Mon, 1 Aug 2022 11:09:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1659352145; bh=tfx740fNJTOmx1aSepgTjvdyrSAGTVbfsKqeiddsPjs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mV/GhBRSc7gFQ7qefvOxaEthH68eBWrjpGZFcGFGnaYeI1nlwIv71RBwx38300xNn mGzIwvC/aItVKR0/0CAY3FbG4fu7l1sqwvdgFf+OSTY0sIFpWobtLymw942hac22nY YJfnw38MoCHnhlMZrK87diAnkF1jEtwVC3kBpLq4= Date: Mon, 1 Aug 2022 13:09:02 +0200 From: Greg KH To: Hans-Christian Noren Egtvedt Cc: linux-kernel@vger.kernel.org, Christian Borntraeger , Yury Norov , Allison Randal , Joe Perches , Thomas Gleixner , William Breathitt Gray , Torsten Hilbrich , Andrew Morton , Linus Torvalds Subject: Re: [v4.9 PATCH 1/6] include/uapi/linux/swab.h: fix userspace breakage, use __BITS_PER_LONG for swap Message-ID: References: <20220731182635.1910069-1-hegtvedt@cisco.com> <20220731182635.1910069-2-hegtvedt@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220731182635.1910069-2-hegtvedt@cisco.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 31, 2022 at 08:26:31PM +0200, Hans-Christian Noren Egtvedt wrote: > From: Christian Borntraeger > > QEMU has a funny new build error message when I use the upstream kernel > headers: > > CC block/file-posix.o > In file included from /home/cborntra/REPOS/qemu/include/qemu/timer.h:4, > from /home/cborntra/REPOS/qemu/include/qemu/timed-average.h:29, > from /home/cborntra/REPOS/qemu/include/block/accounting.h:28, > from /home/cborntra/REPOS/qemu/include/block/block_int.h:27, > from /home/cborntra/REPOS/qemu/block/file-posix.c:30: > /usr/include/linux/swab.h: In function `__swab': > /home/cborntra/REPOS/qemu/include/qemu/bitops.h:20:34: error: "sizeof" is not defined, evaluates to 0 [-Werror=undef] > 20 | #define BITS_PER_LONG (sizeof (unsigned long) * BITS_PER_BYTE) > | ^~~~~~ > /home/cborntra/REPOS/qemu/include/qemu/bitops.h:20:41: error: missing binary operator before token "(" > 20 | #define BITS_PER_LONG (sizeof (unsigned long) * BITS_PER_BYTE) > | ^ > cc1: all warnings being treated as errors > make: *** [/home/cborntra/REPOS/qemu/rules.mak:69: block/file-posix.o] Error 1 > rm tests/qemu-iotests/socket_scm_helper.o > > This was triggered by commit d5767057c9a ("uapi: rename ext2_swab() to > swab() and share globally in swab.h"). That patch is doing > > #include > > but it uses BITS_PER_LONG. > > The kernel file asm/bitsperlong.h provide only __BITS_PER_LONG. > > Let us use the __ variant in swap.h > > Link: http://lkml.kernel.org/r/20200213142147.17604-1-borntraeger@de.ibm.com > Fixes: d5767057c9a ("uapi: rename ext2_swab() to swab() and share globally in swab.h") > Signed-off-by: Christian Borntraeger > Cc: Yury Norov > Cc: Allison Randal > Cc: Joe Perches > Cc: Thomas Gleixner > Cc: William Breathitt Gray > Cc: Torsten Hilbrich > Signed-off-by: Andrew Morton > Signed-off-by: Linus Torvalds > (cherry picked from commit 467d12f5c7842896d2de3ced74e4147ee29e97c8) As you are passing on patches from others, it is usually requried that you too sign-off on them. Can you fix that up on this series and resend it so that I can take them? thanks, greg k-h