Re: [GIT PULL] flexible-array transformations in UAPI for 6.0-rc1

Jason Gunthorpe
2022-08-18T12:28:08Z

On Mon, Aug 01, 2022 at 03:31:28PM -0500, Gustavo A. R. Silva wrote:
> The following changes since commit b13baccc3850ca8b8cccbf8ed9912dbaa0fdf7f3:
>
> Linux 5.19-rc2 (2022-06-12 16:11:37 -0700)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git tags/flexible-array-transformations-UAPI-6.0-rc1
>
> for you to fetch changes up to 94dfc73e7cf4a31da66b8843f0b9283ddd6b8381:
>
> treewide: uapi: Replace zero-length arrays with flexible-array members (2022-06-28 21:26:05 +0200)
>
> ----------------------------------------------------------------
> flexible-array transformations in UAPI for 6.0-rc1
>
> Hi Linus,
>
> Please, pull the following treewide patch that replaces zero-length arrays
> with flexible-array members in UAPI. This patch has been baking in
> linux-next for 5 weeks now.
>
> -fstrict-flex-arrays=3 is coming and we need to land these changes
> to prevent issues like these in the short future:
>
> ../fs/minix/dir.c:337:3: warning: 'strcpy' will always overflow; destination buffer has size 0,
> but the source string has length 2 (including NUL byte) [-Wfortify-source]
> strcpy(de3->name, ".");
> ^
>
> Since these are all [0] to [] changes, the risk to UAPI is nearly zero. If
> this breaks anything, we can use a union with a new member name.

This has trobuled the RDMA userspace by creating new compiler warnings..

We discussed this and I thought you agreed not to send these changes?

https://lore.kernel.org/linux-rdma/20220628135623.GA25163@embeddedor/

Jason