From: Ingo Molnar <mingo@kernel.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Paul E . McKenney" <paulmck@kernel.org>,
Boqun Feng <boqun.feng@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>, Paul Turner <pjt@google.com>,
linux-api <linux-api@vger.kernel.org>,
Peter Oskolkov <posk@posk.io>,
Florian Weimer <fweimer@redhat.com>,
Carlos O'Donell <carlos@redhat.com>
Subject: Re: [PATCH 2/2] rseq: Kill process when unknown flags are encountered in ABI structures
Date: Mon, 1 Aug 2022 21:40:48 +0200 [thread overview]
Message-ID: <YugsQDLJJ/385wRP@gmail.com> (raw)
In-Reply-To: <1686554751.93506.1659364793386.JavaMail.zimbra@efficios.com>
* Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
> The projects I know about that use rseq at the moment don't rely on the
> old ABI ignoring unset flags:
>
> - glibc initialize the rseq_abi()->flags to 0 and do not use rseq_abi()->rseq_cs->flags yet.
> - tcmalloc initialize rseq_abi()->flags and rseq_abi()->rseq_cs->flags to 0.
> - librseq (still only a master branch, no officially released public API yet) initialize
> rseq_abi()->flags and rseq_abi()->rseq_cs->cs_flags to 0.
> - the Linux kernel selftests initialize rseq_abi()->flags and rseq_abi()->rseq_cs->cs_flags
> to 0.
> - AFAIK DynamoRIO does not rely on the kernel ignoring unset flags bits.
> - AFAIK CRIU does not rely on the kernel ignoring unset flags bits.
Thanks - that's exhaustive enough.
> If anyone else rely on rseq ignoring those unset flags, please yell now.
Well, people are unlikely to see random lkml mails - but if gets reported
as a regression then we need to revert. But I don't expect it to happen.
Thanks,
Ingo
next prev parent reply other threads:[~2022-08-01 19:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 19:46 [PATCH 1/2] rseq: Deprecate RSEQ_CS_FLAG_NO_RESTART_ON_* flags Mathieu Desnoyers
2022-06-22 19:46 ` [PATCH 2/2] rseq: Kill process when unknown flags are encountered in ABI structures Mathieu Desnoyers
2022-07-26 19:11 ` Mathieu Desnoyers
2022-07-30 8:21 ` [tip: sched/core] " tip-bot2 for Mathieu Desnoyers
2022-08-01 13:25 ` tip-bot2 for Mathieu Desnoyers
2022-08-01 13:32 ` [PATCH 2/2] " Ingo Molnar
2022-08-01 14:25 ` Florian Weimer
2022-08-01 14:42 ` Mathieu Desnoyers
2022-08-01 14:39 ` Mathieu Desnoyers
2022-08-01 19:40 ` Ingo Molnar [this message]
2022-07-26 19:10 ` [PATCH 1/2] rseq: Deprecate RSEQ_CS_FLAG_NO_RESTART_ON_* flags Mathieu Desnoyers
2022-07-30 8:21 ` [tip: sched/core] " tip-bot2 for Mathieu Desnoyers
2022-08-01 13:25 ` tip-bot2 for Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YugsQDLJJ/385wRP@gmail.com \
--to=mingo@kernel.org \
--cc=boqun.feng@gmail.com \
--cc=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=posk@posk.io \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox