linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH linux-next] staging: greybus:using the pm_runtime_resume_and_get  to simplify the code
@ 2022-08-02  7:45 cgel.zte
  2022-08-02  8:19 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-08-02  7:45 UTC (permalink / raw)
  To: linux-kernel; +Cc: gregkh, greybus-dev, ye xingchen, Zeal Robot

From: ye xingchen <ye.xingchen@zte.com.cn>

Using pm_runtime_resume_and_get() to instade of  pm_runtime_get_sync
and pm_runtime_put_noidle.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
 drivers/greybus/core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/greybus/core.c b/drivers/greybus/core.c
index e546c6431877..b9063e86534b 100644
--- a/drivers/greybus/core.c
+++ b/drivers/greybus/core.c
@@ -174,9 +174,8 @@ static int greybus_probe(struct device *dev)
 	if (!id)
 		return -ENODEV;
 
-	retval = pm_runtime_get_sync(&bundle->intf->dev);
+	retval = pm_runtime_resume_and_get(&bundle->intf->dev);
 	if (retval < 0) {
-		pm_runtime_put_noidle(&bundle->intf->dev);
 		return retval;
 	}
 
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH linux-next] staging: greybus:using the pm_runtime_resume_and_get  to simplify the code
  2022-08-02  7:45 [PATCH linux-next] staging: greybus:using the pm_runtime_resume_and_get to simplify the code cgel.zte
@ 2022-08-02  8:19 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2022-08-02  8:19 UTC (permalink / raw)
  To: cgel.zte; +Cc: linux-kernel, greybus-dev, ye xingchen, Zeal Robot

On Tue, Aug 02, 2022 at 07:45:42AM +0000, cgel.zte@gmail.com wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> Using pm_runtime_resume_and_get() to instade of  pm_runtime_get_sync
> and pm_runtime_put_noidle.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>

Please follow the rules in
Documentation/process/researcher-guidelines.rst for stuff like this,
otherwise I have to reject it.

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-08-02  8:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-02  7:45 [PATCH linux-next] staging: greybus:using the pm_runtime_resume_and_get to simplify the code cgel.zte
2022-08-02  8:19 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).