From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CA13C00140 for ; Tue, 2 Aug 2022 14:36:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237171AbiHBOgg (ORCPT ); Tue, 2 Aug 2022 10:36:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237309AbiHBOgd (ORCPT ); Tue, 2 Aug 2022 10:36:33 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46D7215704; Tue, 2 Aug 2022 07:36:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D66BEB81F38; Tue, 2 Aug 2022 14:36:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F3F34C43470; Tue, 2 Aug 2022 14:36:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1659450988; bh=+PJ10EgQjsPT7oxrxxYmU/pdwHPBRJXP/f0aFyyVyCo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CYRkGnkk7ynHJXIZFQNM2lzIiYDPvGvdardxlgv3WKP3YjAqplJP37mAp0Er0wzyU +wRwq7q3iMcx63hti66TQjI5tRc9OUyo/KMpUGYUcIBOJ7gBIzd7xm9eyI1H5g0mOj DFr1Y1gO3rGXxJnsArwmoO64yJh/a+kBiJ1h108I= Date: Tue, 2 Aug 2022 16:36:25 +0200 From: Greg Kroah-Hartman To: Miguel Ojeda Cc: Miguel Ojeda , Linus Torvalds , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Jarkko Sakkinen , Wedson Almeida Filho , Alex Gaynor , Geoffrey Thomas , Finn Behrens , Adam Bratschi-Kaye , Michael Ellerman , Sumera Priyadarsini , Sven Van Asbroeck , Gary Guo , Boris-Chengbiao Zhou , Boqun Feng , Fox Chen , Dan Robertson , Viktor Garske , Dariusz Sosnowski , =?iso-8859-1?B?TOlv?= Lanteri Thauvin , Niklas Mohrin , Gioh Kim , Daniel Xu , Milan Landaverde , Morgan Bartlett , Maciej Falkowski , Jiapeng Chong , =?iso-8859-1?Q?N=E1ndor_Istv=E1n_Kr=E1cser?= , David Gow , John Baublitz , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron Subject: Re: [PATCH v8 17/31] rust: add `kernel` crate Message-ID: References: <20220802015052.10452-1-ojeda@kernel.org> <20220802015052.10452-18-ojeda@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 02, 2022 at 04:33:17PM +0200, Miguel Ojeda wrote: > Hi Greg, > > On Tue, Aug 2, 2022 at 3:34 PM Greg Kroah-Hartman > wrote: > > > > This is huge for a single commit, and pretty much impossible to review > > as-is. > > > > Any chance you can turn this into a series of commits, that starts with > > the basics and builds on top of that? Right now you are mixing many > > many different subsystems all at once into one commit, guaranteeing that > > no one can review the whole thing properly :( > > Yeah, of course, I am happy to do that -- I did it for the `sync` > module, but stopped splitting further since I understood you wanted it > this way from what you told me on February. I did? Maybe I didn't realize we would end up with 15k lines of code from different parts of the kernel like amba bus and filesystem apis all in a single commit. If so, my fault, but as other parts of this discussion show, it is going to be required to get the subsystem maintainers to be able to review the interfaces to their code in order to get any further. thanks, greg k-h