public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
	"Peter Zijlstra" <peterz@infradead.org>,
	bpf <bpf@vger.kernel.org>, "Kernel Team" <kernel-team@fb.com>,
	linux-kernel@vger.kernel.org, "Andy Lutomirski" <luto@kernel.org>,
	"Daniel Müller" <deso@posteo.net>
Subject: Re: [PATCH] x86/kprobes: Fix to update kcb status flag after singlestepping
Date: Tue, 2 Aug 2022 19:28:56 +0200	[thread overview]
Message-ID: <Yule2F3i+Qj6Cdxc@gmail.com> (raw)
In-Reply-To: <20220802105230.43bb6079@gandalf.local.home>


* Steven Rostedt <rostedt@goodmis.org> wrote:

> On Tue,  2 Aug 2022 15:04:16 +0900
> "Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
> 
> > From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> > 
> > Fix kprobes to update kcb (kprobes control block) status flag to
> > KPROBE_HIT_SSDONE even if the kp->post_handler is not set.
> > This may cause a kernel panic if another int3 user runs right
> > after kprobes because kprobe_int3_handler() misunderstands the
> > int3 is kprobe's single stepping int3.
> > 
> > Fixes: 6256e668b7af ("x86/kprobes: Use int3 instead of debug trap for single-step")
> > Reported-by: Daniel Müller <deso@posteo.net>
> > Tested-by: Daniel Müller <deso@posteo.net>
> > Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> > Cc: stable@vger.kernel.org
> > Link: https://lore.kernel.org/all/20220727210136.jjgc3lpqeq42yr3m@muellerd-fedora-PC2BDTX9
> > ---
> 
> Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> 
> I guess this will go through the tip tree?

Yeah, it's already in tip:perf/urgent.

Thanks,

	Ingo

      reply	other threads:[~2022-08-02 17:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-02  6:04 [PATCH] x86/kprobes: Fix to update kcb status flag after singlestepping Masami Hiramatsu (Google)
2022-08-02 14:52 ` Steven Rostedt
2022-08-02 17:28   ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yule2F3i+Qj6Cdxc@gmail.com \
    --to=mingo@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=deso@posteo.net \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox