From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9869C19F2B for ; Tue, 2 Aug 2022 19:56:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231892AbiHBT4O (ORCPT ); Tue, 2 Aug 2022 15:56:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229504AbiHBT4L (ORCPT ); Tue, 2 Aug 2022 15:56:11 -0400 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC1E7FD1A for ; Tue, 2 Aug 2022 12:56:10 -0700 (PDT) Received: by mail-pg1-x535.google.com with SMTP id 206so9757429pgb.0 for ; Tue, 02 Aug 2022 12:56:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=ifexnCMHYvvlc34nu1xb2qsCA6kxwpy+X5K2hbG8gi8=; b=PHXYjGFlIIXjhXIBuPjNt53vqsnJaXzf/SlvkNEMo+ps28jBD6Ez/yl7i4fDsL/ODz RGKdOQr+K3zKh7Qn+pPq6ceQ3B7cbr7+M1Qfb3odpg8oYs/KZDQ8kjFzsTRDaU3/xtfs IgLMDz7I/u8hact9Ohz75x2gbWl1DKRhxV2dau4ueFhopzIfAUZUGBRROy8GnjHK9RKE SoFluR8JyeawX0BHnCOJ1RpyE56kC0uo/W+1r9hi/HWHJYr1P19Ngr5Bh/TN5EFhAElo mUBDlZQRgq5TYKts03lE/vTqHac2FwQeK495/HqSD0w3oAbcc21xMFG3+AgALrmD8X1X By4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=ifexnCMHYvvlc34nu1xb2qsCA6kxwpy+X5K2hbG8gi8=; b=gvP8u2SzRkCeRDkuBx7DtYY2/sldNEB/8VKqvJvopso57J3XI4ykfg+XUR+1pk43aX 0/IS4XLY7zuBnZUT1sHgZVY7spSwRSS1mI+MKuypRjfpS8u+SIYSMfqLOsTFmw0XwW6Q Ej/cEZJBFmUPUDnANbyy/ke8QSmsbVhITwfG2t2m6+fbfp8uoLE/dtkgOzyPV1deX57j xM/1NYwSrqFDyHsKiBWBiCejpJjdjoG9y3Tt/Zesb9I1JDNJhaWjOeC0OIZP+yKpRsJj BchG/PUA2zCc0WAn5hqGJGGWE75/TMKHu590JOcFDenJzuIBP97jiY4J9yQBDmep3TOF mX7Q== X-Gm-Message-State: AJIora+cCDI9jHyySVqmKPJLVxOXdBCGFS8y3yIy0at5VHvp7xP/8eUQ Nhih8ASzlA90dm1V9Ft7aVaGkg== X-Google-Smtp-Source: AGRyM1u6USAMGnNDWbX+/eMDa6MiHd8/m4L9+0+lgc8NQu+auOJQxzlr1CTmszwb5mlU40S2nv8NAw== X-Received: by 2002:a05:6a00:248b:b0:52b:f07b:796c with SMTP id c11-20020a056a00248b00b0052bf07b796cmr21929332pfv.47.1659470170306; Tue, 02 Aug 2022 12:56:10 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id t14-20020aa7946e000000b0052d9b4bd8fasm4229798pfq.38.2022.08.02.12.56.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Aug 2022 12:56:09 -0700 (PDT) Date: Tue, 2 Aug 2022 19:56:05 +0000 From: Sean Christopherson To: isaku.yamahata@intel.com Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com, Paolo Bonzini Subject: Re: [PATCH v7 028/102] KVM: TDX: allocate/free TDX vcpu structure Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 27, 2022, isaku.yamahata@intel.com wrote: > +int tdx_vcpu_create(struct kvm_vcpu *vcpu) > +{ > + struct vcpu_tdx *tdx = to_tdx(vcpu); > + int ret, i; > + > + /* TDX only supports x2APIC, which requires an in-kernel local APIC. */ > + if (!vcpu->arch.apic) > + return -EINVAL; > + > + fpstate_set_confidential(&vcpu->arch.guest_fpu); > + > + ret = tdx_alloc_td_page(&tdx->tdvpr); > + if (ret) > + return ret; > + > + tdx->tdvpx = kcalloc(tdx_caps.tdvpx_nr_pages, sizeof(*tdx->tdvpx), > + GFP_KERNEL_ACCOUNT); > + if (!tdx->tdvpx) { > + ret = -ENOMEM; > + goto free_tdvpr; > + } > + for (i = 0; i < tdx_caps.tdvpx_nr_pages; i++) { > + ret = tdx_alloc_td_page(&tdx->tdvpx[i]); > + if (ret) > + goto free_tdvpx; > + } Similar to HKID allocation for intrahost migration, can the TDVPX allocations be moved to KVM_TDX_INIT_VCPU?