From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86E23C19F2C for ; Tue, 2 Aug 2022 23:06:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233094AbiHBXGB (ORCPT ); Tue, 2 Aug 2022 19:06:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229568AbiHBXF5 (ORCPT ); Tue, 2 Aug 2022 19:05:57 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84C3CB4B2 for ; Tue, 2 Aug 2022 16:05:56 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id p8so14754218plq.13 for ; Tue, 02 Aug 2022 16:05:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=wkXcbAtsTpJ1ukb80aJGh/l5z35GVyN0XfgbZ64+jZU=; b=jfWsNf0gfrmanpRM9FP43I36ax0jnpdeIKl5U+wS3BKqUpR0kfxXYSvjE8BVEljJri 5IfnHo+OsNMn3s1BtlEx5AACSzeovNt8aVl6Z1QyJRFSd6ENcVqbJr8I2Xh4+eDEaWWP dHVc2OjSmiPvrYZL2VZmd5AF/8dJxPMLw4H6y7giZfeGXSJSdaZNQceOxgvdDQLISxW/ AthBPaNquvOKJWkgNWPycUa7PvPfwn9q4qSEb4QS2aO+pN8m04W+1w3oM87Z8z4e5j6n jhSqVcNty6aRQkhQ/CDEXt7C8zYtwX+0/wujjiIr6gZmYCau20munqZRnqW2gPkgcDj+ Po6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=wkXcbAtsTpJ1ukb80aJGh/l5z35GVyN0XfgbZ64+jZU=; b=lMXiGZgaK4Cb8OEzZuZu3DwX4cimzSLq8aeK6P3zfmVan1gGDfr98rZLnGgqVSmqGh y7Z54IpM4utD1tP37AlJFhAsI0QiJT8xTGmR7YxGzLKb6pj+ngoky9DBuHqKXveiDQfw FY9ZGUQjiS/bHz6h5abgvcQDWix30O28NYo54D/8gbpgB8IshFB67+ZVsIUxd3UwbbUf tlrdcDHndrss99wsTta5YOHa3i9/phkk71JbFH7j0UoQuYprCAe8DYYdICuBIM/RudLF gUGm1ef9+BT2XOETsNJS/XDZPwMR0KzAaGJ2nOBUrwq1MGShrRNwC6MRqHvayuR0SvYv lHgA== X-Gm-Message-State: ACgBeo1N04CJpf+80uRMrRKkvrqRtYGauvhalCCO1UYqIItKZQCrm0WT TjEW8qxdb17Ns86/H15mOXdEIA== X-Google-Smtp-Source: AA6agR5sGknDEK7qmInIe6vO3XynoXQDjKnAl4JMHB6e+1hOUeBQIKAUDAOuFg3LXjEaFbOkJbXvSA== X-Received: by 2002:a17:90a:f481:b0:1f2:43c:a61 with SMTP id bx1-20020a17090af48100b001f2043c0a61mr1909436pjb.134.1659481555927; Tue, 02 Aug 2022 16:05:55 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id t2-20020a1709027fc200b0016dafeda062sm221174plb.232.2022.08.02.16.05.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Aug 2022 16:05:55 -0700 (PDT) Date: Tue, 2 Aug 2022 23:05:51 +0000 From: Sean Christopherson To: Kai Huang Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Roth , Tom Lendacky Subject: Re: [PATCH 2/4] KVM: x86/mmu: Fully re-evaluate MMIO caching when SPTE masks change Message-ID: References: <20220728221759.3492539-3-seanjc@google.com> <9104e22da628fef86a6e8a02d9d2e81814a9d598.camel@intel.com> <244f619a4e7a1c7079830d12379872a111da418d.camel@intel.com> <4fd3cea874b69f1c8bbcaf19538c7fdcb9c22aab.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 03, 2022, Kai Huang wrote: > On Tue, 2022-08-02 at 21:15 +0000, Sean Christopherson wrote: > > On Tue, Aug 02, 2022, Kai Huang wrote: > > > But we are not checking any of those in kvm_mmu_set_mmio_spte_mask(), right? :) > > > > No, but we really should. > > I can come up a patch if you are not planning to do so? Hmm, I'll throw one together, it's simple enough (famous last words) and it'll need to be tested on AMD as well.