From: Greg KH <gregkh@linuxfoundation.org>
To: cgel.zte@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
ye xingchen <ye.xingchen@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH linux-next] USB: apple-mfi-fastcharge:using the pm_runtime_resume_and_get to simplify the code
Date: Wed, 3 Aug 2022 08:16:39 +0200 [thread overview]
Message-ID: <YuoSx2Te30HxATlE@kroah.com> (raw)
In-Reply-To: <20220803061452.1650472-1-ye.xingchen@zte.com.cn>
On Wed, Aug 03, 2022 at 06:14:52AM +0000, cgel.zte@gmail.com wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Using pm_runtime_resume_and_get() to instade of pm_runtime_get_sync
> and pm_runtime_put_noidle.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
> drivers/usb/misc/apple-mfi-fastcharge.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/usb/misc/apple-mfi-fastcharge.c b/drivers/usb/misc/apple-mfi-fastcharge.c
> index ac8695195c13..1bf9a67f4cca 100644
> --- a/drivers/usb/misc/apple-mfi-fastcharge.c
> +++ b/drivers/usb/misc/apple-mfi-fastcharge.c
> @@ -119,9 +119,8 @@ static int apple_mfi_fc_set_property(struct power_supply *psy,
>
> dev_dbg(&mfi->udev->dev, "prop: %d\n", psp);
>
> - ret = pm_runtime_get_sync(&mfi->udev->dev);
> + ret = pm_runtime_resume_and_get(&mfi->udev->dev);
> if (ret < 0) {
> - pm_runtime_put_noidle(&mfi->udev->dev);
> return ret;
> }
>
> --
> 2.25.1
For some reason you ignored my request in:
https://lore.kernel.org/r/YujeLEMsIrVD2tGn@kroah.com
so I'll just add your email to my discard list for a while, sorry.
greg k-h
prev parent reply other threads:[~2022-08-03 6:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 6:14 [PATCH linux-next] USB: apple-mfi-fastcharge:using the pm_runtime_resume_and_get to simplify the code cgel.zte
2022-08-03 6:16 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuoSx2Te30HxATlE@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=cgel.zte@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ye.xingchen@zte.com.cn \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox