From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D928C19F28 for ; Wed, 3 Aug 2022 07:31:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234221AbiHCHaw (ORCPT ); Wed, 3 Aug 2022 03:30:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234370AbiHCHal (ORCPT ); Wed, 3 Aug 2022 03:30:41 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27F5E6453; Wed, 3 Aug 2022 00:30:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D9D27B82160; Wed, 3 Aug 2022 07:30:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15C46C433D6; Wed, 3 Aug 2022 07:30:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1659511836; bh=ZOVE5U7SmeP3Je9gS9zhmhPnptosHiQ0OmhkTlqr8cA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HpHEdZXxPknXrXhlL/LGHuMNMPXxbWn2i+ZP7ycgBH1Fsp8iY/qJX6kYu7pcLvcu0 HHWfUUSpMZSqAXTEIHSG9TDmJ2dTnKLwIbjV9yoKDHtxSgm55bX1sz1QbDDyzO0SG3 dBAnb63N7pfE38X3dfLssl5W269hLyNE05tqKH+Q= Date: Wed, 3 Aug 2022 09:30:33 +0200 From: Greg Kroah-Hartman To: Miguel Ojeda Cc: Miguel Ojeda , Linus Torvalds , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Jarkko Sakkinen , Wedson Almeida Filho , Alex Gaynor , Geoffrey Thomas , Finn Behrens , Adam Bratschi-Kaye , Michael Ellerman , Sumera Priyadarsini , Sven Van Asbroeck , Gary Guo , Boris-Chengbiao Zhou , Boqun Feng , Fox Chen , Dan Robertson , Viktor Garske , Dariusz Sosnowski , =?iso-8859-1?B?TOlv?= Lanteri Thauvin , Niklas Mohrin , Gioh Kim , Daniel Xu , Milan Landaverde , Morgan Bartlett , Maciej Falkowski , Jiapeng Chong , =?iso-8859-1?Q?N=E1ndor_Istv=E1n_Kr=E1cser?= , David Gow , John Baublitz , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron Subject: Re: [PATCH v8 17/31] rust: add `kernel` crate Message-ID: References: <20220802015052.10452-1-ojeda@kernel.org> <20220802015052.10452-18-ojeda@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 02, 2022 at 04:53:17PM +0200, Miguel Ojeda wrote: > On Tue, Aug 2, 2022 at 4:36 PM Greg Kroah-Hartman > wrote: > > > > I did? Maybe I didn't realize we would end up with 15k lines of code > > from different parts of the kernel like amba bus and filesystem apis all > > in a single commit. If so, my fault, but as other parts of this > > discussion show, it is going to be required to get the subsystem > > maintainers to be able to review the interfaces to their code in order > > to get any further. > > No worries at all! Probably a misunderstanding on my side too. > > I am more than happy to spit it into quite a few patches, and it will > also help with the C-d-b's. > > As for reviewing -- since we keep adding abstractions and new features > to show how things may work, we would be chasing new reviews all the > time. Would it be better to drop some of those for the moment and get > the "core" in first? Yes, it would be good to drop almost all of these for now, anything you do not have an in-tree user for, should not be present in anything you submit upstream. > That way we can merge each subsystem part by part later, send it to > the proper MLs as smaller patches, get maintainers on board, etc. > etc., and it would be more manageable for everyone. Yes, that would be the normal review process. thanks, greg k-h