public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	Andrey Strachuk <strochuk@ispras.ru>
Subject: Re: [GIT PULL] USB / Thunderbolt driver changes for 6.0-rc1
Date: Wed, 3 Aug 2022 08:43:49 -0700	[thread overview]
Message-ID: <YuqXtcaUPflINBd6@dev-arch.thelio-3990X> (raw)
In-Reply-To: <YuqB0tl2hjT3x7a4@kroah.com>

On Wed, Aug 03, 2022 at 04:10:26PM +0200, Greg KH wrote:
> Andrey Strachuk (1):
>       usb: cdns3: change place of 'priv_ep' assignment in cdns3_gadget_ep_dequeue(), cdns3_gadget_ep_enable()

For the record, this breaks allmodconfig with clang (I haven't seen a
formal report on it anywhere and this missed -next coverage because
Stephen is on vacation):

    drivers/usb/cdns3/cdns3-gadget.c:2290:11: error: variable 'priv_dev' is uninitialized when used here [-Werror,-Wuninitialized]
                    dev_dbg(priv_dev->dev, "usbss: invalid parameters\n");
                            ^~~~~~~~
    include/linux/dev_printk.h:155:18: note: expanded from macro 'dev_dbg'
            dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
                            ^~~
    include/linux/dynamic_debug.h:167:7: note: expanded from macro 'dynamic_dev_dbg'
                            dev, fmt, ##__VA_ARGS__)
                            ^~~
    include/linux/dynamic_debug.h:152:56: note: expanded from macro '_dynamic_func_call'
            __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
                                                                ^~~~~~~~~~~
    include/linux/dynamic_debug.h:134:15: note: expanded from macro '__dynamic_func_call'
                    func(&id, ##__VA_ARGS__);               \
                                ^~~~~~~~~~~
    drivers/usb/cdns3/cdns3-gadget.c:2278:31: note: initialize the variable 'priv_dev' to silence this warning
            struct cdns3_device *priv_dev;
                                        ^
                                        = NULL
    1 error generated.

I know you don't take patches during the merge window, so I guess we'll
just have to have x86_64 allmodconfig be broken with clang for -rc1? :/

Cheers,
Nathan

  reply	other threads:[~2022-08-03 15:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-03 14:10 [GIT PULL] USB / Thunderbolt driver changes for 6.0-rc1 Greg KH
2022-08-03 15:43 ` Nathan Chancellor [this message]
2022-08-03 15:50   ` Greg KH
2022-08-03 15:56     ` Krishna Kurapati PSSNV
2022-08-08 13:07       ` Greg KH
2022-08-03 15:58     ` Nathan Chancellor
2022-08-04 18:45   ` Linus Torvalds
2022-08-04 18:50     ` Nathan Chancellor
2022-08-04 19:26 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YuqXtcaUPflINBd6@dev-arch.thelio-3990X \
    --to=nathan@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=strochuk@ispras.ru \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox