From: Sean Christopherson <seanjc@google.com>
To: Kai Huang <kai.huang@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: x86/mmu: Add sanity check that MMIO SPTE mask doesn't overlap gen
Date: Wed, 3 Aug 2022 22:49:20 +0000 [thread overview]
Message-ID: <Yur7cGigN3MIrQO9@google.com> (raw)
In-Reply-To: <be0767a74a80cf8d749003cc73a9aa316ab49821.camel@intel.com>
On Thu, Aug 04, 2022, Kai Huang wrote:
> On Wed, 2022-08-03 at 21:33 +0000, Sean Christopherson wrote:
> > Add compile-time and init-time sanity checks to ensure that the MMIO SPTE
> > mask doesn't overlap the MMIO SPTE generation. The generation currently
> > avoids using bit 63, but that's as much coincidence as it is strictly
> > necessarly. That will change in the future, as TDX support will require
> > setting bit 63 (SUPPRESS_VE) in the mask. Explicitly carve out the bits
> > that are allowed in the mask so that any future shuffling of SPTE MMIO
> > bits doesn't silently break MMIO caching.
>
> Reviwed-by: Kai Huang <kai.huang@intel.com>
>
> Btw, should you also check SPTE_MMU_PRESENT_MASK (or in another patch)?
Rats, I thought we already checked that, but it's only the MMIO generation that
checks for overlap. I'll send a v2.
prev parent reply other threads:[~2022-08-03 22:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 21:33 [PATCH] KVM: x86/mmu: Add sanity check that MMIO SPTE mask doesn't overlap gen Sean Christopherson
2022-08-03 22:46 ` Kai Huang
2022-08-03 22:49 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yur7cGigN3MIrQO9@google.com \
--to=seanjc@google.com \
--cc=kai.huang@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox