* [PATCH] rv: Unlock on error path in rv_unregister_reactor()
@ 2022-08-04 14:33 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2022-08-04 14:33 UTC (permalink / raw)
To: Steven Rostedt, Daniel Bristot de Oliveira
Cc: Ingo Molnar, linux-kernel, kernel-janitors
Unlock the "rv_interface_lock" mutex before returning.
Fixes: 04acadcb4453 ("rv: Add runtime reactors interface")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
kernel/trace/rv/rv_reactors.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/kernel/trace/rv/rv_reactors.c b/kernel/trace/rv/rv_reactors.c
index a6522c196382..6aae106695b6 100644
--- a/kernel/trace/rv/rv_reactors.c
+++ b/kernel/trace/rv/rv_reactors.c
@@ -329,6 +329,7 @@ int rv_register_reactor(struct rv_reactor *reactor)
int rv_unregister_reactor(struct rv_reactor *reactor)
{
struct rv_reactor_def *ptr, *next;
+ int ret = 0;
mutex_lock(&rv_interface_lock);
@@ -343,13 +344,14 @@ int rv_unregister_reactor(struct rv_reactor *reactor)
ptr->reactor->name, ptr->counter);
printk(KERN_WARNING "rv: the rv_reactor %s cannot be removed\n",
ptr->reactor->name);
- return -EBUSY;
+ ret = -EBUSY;
+ break;
}
}
}
mutex_unlock(&rv_interface_lock);
- return 0;
+ return ret;
}
/*
--
2.35.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-08-04 14:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-04 14:33 [PATCH] rv: Unlock on error path in rv_unregister_reactor() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox