From: Ondrej Zajicek <santiago@crfreenet.org>
To: Zheyu Ma <zheyuma97@gmail.com>
Cc: deller@gmx.de, adaplas@gmail.com, akpm@linux-foundation.org,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] Fix bugs in *_set_par() caused by user input
Date: Thu, 4 Aug 2022 16:43:47 +0200 [thread overview]
Message-ID: <YuvbI8NEpzciTgfc@finarfin> (raw)
In-Reply-To: <20220804124125.3506755-1-zheyuma97@gmail.com>
On Thu, Aug 04, 2022 at 08:41:22PM +0800, Zheyu Ma wrote:
> In the function *_set_par(), the value of 'screen_size' is
> calculated by the user input. If the user provides the improper value,
> the value of 'screen_size' may larger than 'info->screen_size', which
> may cause a bug in the memset_io().
Hi
I did not saw fbdev code in years, but should not this be already checked
by *_check_var() ?
arkfb_check_var():
...
/* Check whether have enough memory */
mem = ((var->bits_per_pixel * var->xres_virtual) >> 3) * var->yres_virtual;
if (mem > info->screen_size)
...
--
Elen sila lumenn' omentielvo
Ondrej 'Santiago' Zajicek (email: santiago@crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."
next prev parent reply other threads:[~2022-08-04 14:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 12:41 [PATCH 0/3] Fix bugs in *_set_par() caused by user input Zheyu Ma
2022-08-04 12:41 ` [PATCH 1/3] video: fbdev: vt8623fb: Check the size of screen before memset_io() Zheyu Ma
2022-08-04 12:41 ` [PATCH 2/3] video: fbdev: arkfb: " Zheyu Ma
2022-08-04 12:41 ` [PATCH 3/3] video: fbdev: s3fb: " Zheyu Ma
2022-08-04 14:43 ` Ondrej Zajicek [this message]
2022-08-05 2:48 ` [PATCH 0/3] Fix bugs in *_set_par() caused by user input Zheyu Ma
2022-08-05 16:47 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuvbI8NEpzciTgfc@finarfin \
--to=santiago@crfreenet.org \
--cc=adaplas@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zheyuma97@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox