From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A0E9C00140 for ; Fri, 5 Aug 2022 07:42:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237913AbiHEHmD (ORCPT ); Fri, 5 Aug 2022 03:42:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236877AbiHEHmA (ORCPT ); Fri, 5 Aug 2022 03:42:00 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E39EDF79 for ; Fri, 5 Aug 2022 00:41:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7FA1C6165E for ; Fri, 5 Aug 2022 07:41:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88270C433D6; Fri, 5 Aug 2022 07:41:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1659685318; bh=LYjw9sZ77GvuSRMeFbpQJ5uL+nJRQx5yZzbOtk0w73E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gHweLuE5mbnfg/EUBqPDDnNTuPC+/tlrHr1OCDJVM0WuXRmQbC/74xEkCAqDbgrJF IUHib03Ng0Qz97fZPuz6zO65sEw7pcs0sbff0wCaeQnOhBP+jCX4VLedGQ+9RHZWZs zD2v5Hh7q6gv5CleaL20YfuYp0A0eEdYaSZKtOko= Date: Fri, 5 Aug 2022 09:41:56 +0200 From: Greg KH To: Simone Serra Cc: fabioaiuto83@gmail.com, soumya.negi97@gmail.com, hdegoede@redhat.com, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fixes checkpatch warnings and checks Message-ID: References: <20220805073932.225975-1-serrazimone@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220805073932.225975-1-serrazimone@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 05, 2022 at 09:39:32AM +0200, Simone Serra wrote: > Fixes checkpatch warningds and checks > > Signed-off-by: Simone Serra > --- > drivers/staging/rtl8723bs/core/rtw_ap.c | 462 +++++++++++------------- > 1 file changed, 220 insertions(+), 242 deletions(-) > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause. - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot