Re: [RFC PATCH v2 2/6] bus/cdx: add the cdx bus driver

Marc Zyngier
2022-08-17T15:46:36Z

On Wed, 17 Aug 2022 16:32:45 +0100,
Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Wed, Aug 17, 2022 at 08:35:38PM +0530, Nipun Gupta wrote:
> > CDX bus driver manages the scanning and populating FPGA
> > based devices present on the CDX bus.
> >
> > The bus driver sets up the basic infrastructure and fetches
> > the device related information from the firmware. These
> > devices are registered as platform devices.
>
> Ick, why? These aren't platform devices, they are CDX devices. Make
> them real devices here, don't abuse the platform device interface for
> things that are not actually on the platform bus.
>
> > CDX bus is capable of scanning devices dynamically,
> > supporting rescanning of dynamically added, removed or
> > updated devices.
>
> Wonderful, that's a real bus, so be a real bus please.

+1.

This should follow something like PCI, which has semi-sane semantics.

Thanks,

M.

--
Without deviation from the norm, progress is not possible.