Re: [PATCH v2 3/4] arm64: dts: qcom: sdm845: Add the RPMh stats node

Caleb Connolly
2022-08-16T00:27:36Z

On 12/08/2022 11:12, Abel Vesa wrote:
> SDM845 is a special case compared to the other platforms that use RPMh
> stats, since it only has 2 stats (aosd and cxsd), while the others have
> a 3rd one (ddr).
>
> So lets add the node but with a SDM845 dedicated compatible to make
> the driver aware of the different stats config.
Hi,

I gave this a go on the OnePlus 6, I noticed the driver is also meant to read
the stats for remote procs via smem, however this seems to fail for me - it
can't find any of the SMEM items even if I probe the driver manually after
ensuring remoteprocs have booted. Is this an unsupported feature on SDM845?
>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>
> Changed qcom,rpmh-stats-sdm845 to qcom,sdm845-rpmh-stats, as suggested
> by Krzysztof.
>
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 5bea96a9ce06..67fe08b837be 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -4851,6 +4851,11 @@ ebi_cdev: ebi {
> };
> };
>
> + sram@c3f0000 {
> + compatible = "qcom,sdm845-rpmh-stats";
> + reg = <0 0x0c3f0000 0 0x400>;
> + };
> +
> spmi_bus: spmi@c440000 {
> compatible = "qcom,spmi-pmic-arb";
> reg = <0 0x0c440000 0 0x1100>,
> --
> 2.34.1
>

--
Kind Regards,
Caleb (they/he)