From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE756C32771 for ; Fri, 19 Aug 2022 09:12:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347650AbiHSJMj (ORCPT ); Fri, 19 Aug 2022 05:12:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242959AbiHSJMh (ORCPT ); Fri, 19 Aug 2022 05:12:37 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE7A7F23E2; Fri, 19 Aug 2022 02:12:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B3005B82733; Fri, 19 Aug 2022 09:12:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27B5BC433C1; Fri, 19 Aug 2022 09:12:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660900354; bh=efnz7ZSxmdtNAUgLtC5im9eNjnbCOkKCjkxJDQwSmDs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bTqtNLWeseKUDCfpTCAL7etDy68BAARPCMf/vm5kYHjXXMGVShi9BjaDCl0T/BytK PmzMkOLUi4wsvNgWrWR8c/HmUsHnjBT6dw9y7nsweGAHXakKmLNueLo82RuklK4pAJ j9TGPlOma6uCSggOmHsrX9u4dGemFgzVnn6+EXfE= Date: Fri, 19 Aug 2022 11:12:32 +0200 From: Greg KH To: Thierry GUIBERT Cc: oneukum@suse.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, thierry.guibert@free.fr Subject: Re: [PATCH] CDC-ACM : Add Icom PMR F3400 support (0c26:0020) Message-ID: References: <20220819081702.84118-1-thierry.guibert@croix-rouge.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220819081702.84118-1-thierry.guibert@croix-rouge.fr> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 19, 2022 at 10:17:02AM +0200, Thierry GUIBERT wrote: > Supports for ICOM F3400 and ICOM F4400 PMR radios in CDC-ACM driver > enabling the AT serial port. > The Vendor Id is 0x0C26 > The Product ID is 0x0020 > > Output of lsusb : > Bus 001 Device 009: ID 0c26:0020 Prolific Technology Inc. ICOM Radio > Couldn't open device, some information will be missing > Device Descriptor: > bLength 18 > bDescriptorType 1 > bcdUSB 2.00 > bDeviceClass 2 Communications > bDeviceSubClass 0 > bDeviceProtocol 0 > bMaxPacketSize0 64 > idVendor 0x0c26 Prolific Technology Inc. > idProduct 0x0020 > bcdDevice 0.00 > iManufacturer 1 ICOM Inc. > iProduct 2 ICOM Radio > iSerial 3 *obfuscated* > bNumConfigurations 1 > Configuration Descriptor: > bLength 9 > bDescriptorType 2 > wTotalLength 0x0030 > bNumInterfaces 2 > bConfigurationValue 1 > iConfiguration 0 > bmAttributes 0xc0 > Self Powered > MaxPower 0mA > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 0 > bAlternateSetting 0 > bNumEndpoints 1 > bInterfaceClass 2 Communications > bInterfaceSubClass 2 Abstract (modem) > bInterfaceProtocol 1 AT-commands (v.25ter) > iInterface 0 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x83 EP 3 IN > bmAttributes 3 > Transfer Type Interrupt > Synch Type None > Usage Type Data > wMaxPacketSize 0x0040 1x 64 bytes > bInterval 12 > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 1 > bAlternateSetting 0 > bNumEndpoints 2 > bInterfaceClass 10 CDC Data > bInterfaceSubClass 0 > bInterfaceProtocol 0 > iInterface 0 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x82 EP 2 IN > bmAttributes 2 > Transfer Type Bulk > Synch Type None > Usage Type Data > wMaxPacketSize 0x0200 1x 512 bytes > bInterval 0 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x02 EP 2 OUT > bmAttributes 2 > Transfer Type Bulk > Synch Type None > Usage Type Data > wMaxPacketSize 0x0200 1x 512 bytes > bInterval 0 > > Signed-off-by: Thierry GUIBERT > --- > drivers/usb/class/cdc-acm.c | 3 +++ > 1 file changed, 3 insertions(+) Note, this is the second version of this patch, so it should have had "v2" in the subject area, and below the --- line a description of what changed from the previous one, so we can have some context here. The kernel documentation on submitting patches explains how to do this for your next time, for now, I'll take this as-is, thanks. greg k-h