From: Lee Jones <lee.jones@linaro.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
linux-kernel@vger.kernel.org, Lee Jones <lee@kernel.org>,
Andy Shevchenko <andy@kernel.org>
Subject: Re: [PATCH v3 07/10] mfd: intel_soc_pmic_crc: Drop redundant ACPI_PTR() and ifdeffery
Date: Mon, 8 Aug 2022 17:13:26 +0100 [thread overview]
Message-ID: <YvE2JkKdVA7cpE07@google.com> (raw)
In-Reply-To: <20220801114211.36267-7-andriy.shevchenko@linux.intel.com>
On Mon, 01 Aug 2022, Andy Shevchenko wrote:
> The driver depends on ACPI, ACPI_PTR() resolution is always the same.
> Otherwise a compiler may produce a warning.
>
> That said, the rule of thumb either ugly ifdeffery with ACPI_PTR or
> none should be used in a driver.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Tested-by: Hans de Goede <hdegoede@redhat.com>
> Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
> ---
>
> v3: no changes
> v2: added tags and rebased on top of new patch 1
>
> drivers/mfd/Kconfig | 4 ++--
> drivers/mfd/intel_soc_pmic_crc.c | 6 ++----
> 2 files changed, 4 insertions(+), 6 deletions(-)
Applied, thanks.
--
DEPRECATED: Please use lee@kernel.org
next prev parent reply other threads:[~2022-08-08 16:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 11:42 [PATCH v3 01/10] mfd: intel_soc_pmic: Fix an error handling path in intel_soc_pmic_i2c_probe() Andy Shevchenko
2022-08-01 11:42 ` [PATCH v3 02/10] mfd: intel_soc_pmic_crc: Merge Intel PMIC core to crc Andy Shevchenko
2022-08-08 16:10 ` Lee Jones
2022-08-01 11:42 ` [PATCH v3 03/10] mfd: intel_soc_pmic: Move non-Intel Makefile entries to their own group Andy Shevchenko
2022-08-08 16:10 ` Lee Jones
2022-08-01 11:42 ` [PATCH v3 04/10] mfd: intel_soc_pmic_crc: Use devm_regmap_add_irq_chip() Andy Shevchenko
2022-08-08 16:12 ` Lee Jones
2022-08-01 11:42 ` [PATCH v3 05/10] mfd: intel_soc_pmic_crc: Convert to use i2c_get/set_clientdata() Andy Shevchenko
2022-08-08 16:12 ` Lee Jones
2022-08-01 11:42 ` [PATCH v3 06/10] mfd: intel_soc_pmic_crc: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr() etc Andy Shevchenko
2022-08-08 16:13 ` Lee Jones
2022-08-01 11:42 ` [PATCH v3 07/10] mfd: intel_soc_pmic_crc: Drop redundant ACPI_PTR() and ifdeffery Andy Shevchenko
2022-08-08 16:13 ` Lee Jones [this message]
2022-08-01 11:42 ` [PATCH v3 08/10] mfd: intel_soc_pmic_crc: Convert driver to use ->probe_new() Andy Shevchenko
2022-08-08 16:17 ` Lee Jones
2022-08-01 11:42 ` [PATCH v3 09/10] mfd: intel_soc_pmic_crc: Replace intel_soc_pmic with crystal_cove Andy Shevchenko
2022-08-08 16:18 ` Lee Jones
2022-08-01 11:42 ` [PATCH v3 10/10] mfd: intel_soc_pmic_crc: Update the copyright year Andy Shevchenko
2022-08-08 16:18 ` Lee Jones
2022-08-08 16:09 ` [PATCH v3 01/10] mfd: intel_soc_pmic: Fix an error handling path in intel_soc_pmic_i2c_probe() Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvE2JkKdVA7cpE07@google.com \
--to=lee.jones@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=hdegoede@redhat.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox