From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC4F2C3F6B0 for ; Mon, 8 Aug 2022 13:48:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235211AbiHHNsk (ORCPT ); Mon, 8 Aug 2022 09:48:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232602AbiHHNs3 (ORCPT ); Mon, 8 Aug 2022 09:48:29 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FD2263A5 for ; Mon, 8 Aug 2022 06:48:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A08CC6069F for ; Mon, 8 Aug 2022 13:48:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A08E9C433D6; Mon, 8 Aug 2022 13:48:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659966508; bh=X0HV5fhPXLUm7NKTXFMV95hb8lBSLoQ/OJXqnQiMfK0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oRGo0mtjC6m1kP8UNXbybRa2Un2g7srfKYkfWbpIqWQ4Jl3ohLQSnSGtNgy+AS5se Zlr61V1czlqDFVdSn68EcckmBlpgZckNbv3edSxNw0LQWm9pmasiPNwVVr7khs12rW fZ2Q9qZMTlJojiRf5JUvWqmZO4vViPO+LCGN1wWBnItnBYBK1csV8cK05RZFF/KW8+ qy7OGGgsXL/UKpvKRGfCdhWabGXh1gwGKP/wOL9/K3pvKF021bhh9dXR/AxoSatir1 +1zRiAEM5HKUuwTZQ9E55wwVR45pWUqKEYrSEipItiBL6bYXpgqXijI4lpyTlfVMjH A2bwvOd+qI1QA== Date: Mon, 8 Aug 2022 14:48:23 +0100 From: Mark Brown To: Andy Shevchenko Cc: Andy Shevchenko , Aidan MacDonald , Linux Kernel Mailing List , Greg Kroah-Hartman , "Rafael J. Wysocki" Subject: Re: [PATCH v1 1/5] regmap: mmio: Don't unprepare attached clock Message-ID: References: <20220805205321.19452-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZxuxQCJ31s+QoHqV" Content-Disposition: inline In-Reply-To: X-Cookie: Flee at once, all is discovered. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ZxuxQCJ31s+QoHqV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Aug 08, 2022 at 03:41:48PM +0200, Andy Shevchenko wrote: > On Mon, Aug 8, 2022 at 3:19 PM Mark Brown wrote: > > regmap_mmio_attach_clk() prepares the clock that's passed in, we should > > undo that when detaching otherwise we're leaking a prepare (as we do in > > the explicit detach). > Why do we allow the user to avoid explicit detach? What is the point > of having that API in the case we take care of it? I think just for symmetry so it's obvious that error handling is happening if people want it to be. --ZxuxQCJ31s+QoHqV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmLxFCYACgkQJNaLcl1U h9BdvQf+OJJbTrFaHiI8cc4lrDovCbKsQ559BIfDzBz+m8Kt7j/yaQHHzcjBBn0c 0HyvJKLRNDSwcM/sKIxMWSOxqNH9qi7edMnqJd+tKwjUJZOtJfGuDjNoT3eaYNuL TBpCMPhH4mAyipt1NkcwnGKLELyKQJ7ltiiLtSlqTOmQ9DUA6P342nbdVyvGmxM0 aZ9gmhjZ9gKi51kcsjtjCnwNKwq6TIaJENDBvwLn75WlPhTgQBWyx2ALHU/6ER0y q+IC8cTebkB6MA9oH+6fbFNy7WXdkCj1uA910lAyPg/SqyuVsY9r2csro8IMuGR1 70bd5D1V7CAyBlcZMwaLDDiISTIYww== =e58/ -----END PGP SIGNATURE----- --ZxuxQCJ31s+QoHqV--