From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3617C00140 for ; Mon, 8 Aug 2022 17:38:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243580AbiHHRiq (ORCPT ); Mon, 8 Aug 2022 13:38:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236070AbiHHRio (ORCPT ); Mon, 8 Aug 2022 13:38:44 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D3D615FC8 for ; Mon, 8 Aug 2022 10:38:43 -0700 (PDT) Received: from zn.tnic (p200300ea971b98cb329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:971b:98cb:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 320AF1EC0380; Mon, 8 Aug 2022 19:38:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1659980318; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=QkI3RA/HMmgr+FifC1RD9i6yt0XDfg84AsVGBhRwcU4=; b=UT7H5W6W3k8Hl1lrakgDducomkCaf+Lk5qbTLDbQhLAKFLrFxRKOI1vDSeA3LLo1xkIZ2A 2LbtU03Rpj1AV1aTxz3wSHb7DU3xWSfznugeYtbqpFJrGxzI36P3/P5VFhrgmLuik5RP62 X7DSfuVpB2iER8xPv5R636sVRhl96Ko= Date: Mon, 8 Aug 2022 19:38:37 +0200 From: Borislav Petkov To: Ira Weiny Cc: Rik van Riel , Dave Hansen , Dave Hansen , x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [RFC PATCH 1/5] entry: Pass pt_regs to irqentry_exit_cond_resched() Message-ID: References: <20220805173009.3128098-1-ira.weiny@intel.com> <20220805173009.3128098-2-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 08, 2022 at 10:34:19AM -0700, Ira Weiny wrote: > I thought about that but generally have been steered away from using bool > arguments like this. The reason being? > Looking this over I think this may be a reasonable use of a flag like > that. > > I'm not sure if this series is going to land given the discussion of > performance. Well, the only way to talk performance is to have something to measure it with. But let me finish going through the rest of your set first. > Would this clean up be welcome on its own? I'm willing to respin > this patch and submit if so. Depends on who steered you away from the bool thing and why? :-) Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette