From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: agross@kernel.org, konrad.dybcio@somainline.org,
amitk@kernel.org, thara.gopinath@gmail.com, rafael@kernel.org,
daniel.lezcano@linaro.org, rui.zhang@intel.com,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] thermal/drivers/qcom/spmi-adc-tm5: Remove unnecessary print function dev_err()
Date: Tue, 9 Aug 2022 14:39:33 -0500 [thread overview]
Message-ID: <YvK39TTGdgHV1HSb@baldur> (raw)
In-Reply-To: <20220809034346.128607-1-jiapeng.chong@linux.alibaba.com>
On Mon 08 Aug 22:43 CDT 2022, Jiapeng Chong wrote:
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
>
> ./drivers/thermal/qcom/qcom-spmi-adc-tm5.c:1029:2-9: line 1029 is redundant because platform_get_irq() already prints an error.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1846
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/thermal/qcom/qcom-spmi-adc-tm5.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
> index add6f40e5e2a..af68adf720cc 100644
> --- a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
> +++ b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
> @@ -1025,10 +1025,8 @@ static int adc_tm5_probe(struct platform_device *pdev)
> adc_tm->base = reg;
>
> irq = platform_get_irq(pdev, 0);
> - if (irq < 0) {
> - dev_err(dev, "get_irq failed: %d\n", irq);
> + if (irq < 0)
> return irq;
> - }
>
> ret = adc_tm5_get_dt_data(adc_tm, node);
> if (ret) {
> --
> 2.20.1.7.g153144c
>
next prev parent reply other threads:[~2022-08-09 19:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 3:43 [PATCH] thermal/drivers/qcom/spmi-adc-tm5: Remove unnecessary print function dev_err() Jiapeng Chong
2022-08-09 19:39 ` Bjorn Andersson [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-11-05 1:33 Xu Wang
2021-11-06 15:50 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvK39TTGdgHV1HSb@baldur \
--to=bjorn.andersson@linaro.org \
--cc=abaci@linux.alibaba.com \
--cc=agross@kernel.org \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=thara.gopinath@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox