From: Eric Biggers <ebiggers@kernel.org>
To: Dong Chuanjian <chuanjian@nfschina.com>
Cc: herbert@gondor.apana.org.au, davem@davemloft.net,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@nfschina.com
Subject: Re: [PATCH] crypto/drbg.c:remove unnecessary (void*) conversions
Date: Tue, 9 Aug 2022 18:07:01 +0000 [thread overview]
Message-ID: <YvKiRWzWyATdEwGP@gmail.com> (raw)
In-Reply-To: <20220809091452.5264-1-chuanjian@nfschina.com>
On Tue, Aug 09, 2022 at 05:14:52PM +0800, Dong Chuanjian wrote:
> struct crypto_cipher *tfm =
> - (struct crypto_cipher *)drbg->priv_data;
> + drbg->priv_data;
Might as well join this into one line.
>
> crypto_cipher_setkey(tfm, key, (drbg_keylen(drbg)));
> }
> @@ -1828,7 +1828,7 @@ static int drbg_kcapi_sym(struct drbg_state *drbg, unsigned char *outval,
> const struct drbg_string *in)
> {
> struct crypto_cipher *tfm =
> - (struct crypto_cipher *)drbg->priv_data;
> + drbg->priv_data;
Likewise.
- Eric
next prev parent reply other threads:[~2022-08-09 18:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 9:14 [PATCH] crypto/drbg.c:remove unnecessary (void*) conversions Dong Chuanjian
2022-08-09 18:07 ` Eric Biggers [this message]
2022-08-11 7:17 ` Dong Chuanjian
2022-08-11 7:17 ` [PATCH] crypto/drbg: remove " Dong Chuanjian
2022-08-19 11:03 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvKiRWzWyATdEwGP@gmail.com \
--to=ebiggers@kernel.org \
--cc=chuanjian@nfschina.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kernel@nfschina.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox