From: Johannes Weiner <hannes@cmpxchg.org>
To: Tejun Heo <tj@kernel.org>
Cc: Hao Jia <jiahao.os@bytedance.com>,
mingo@redhat.com, peterz@infradead.org, mingo@kernel.org,
juri.lelli@redhat.com, vincent.guittot@linaro.org,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
vschneid@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] sched/psi: psi bug fixes and cleanups
Date: Wed, 10 Aug 2022 11:13:56 -0400 [thread overview]
Message-ID: <YvPLNNlIyjLXv71v@cmpxchg.org> (raw)
In-Reply-To: <YvKbUbFCaf6WcF26@slm.duckdns.org>
On Tue, Aug 09, 2022 at 07:37:21AM -1000, Tejun Heo wrote:
> (cc'ing Johannes)
>
> On Sat, Aug 06, 2022 at 08:05:07PM +0800, Hao Jia wrote:
> > These three patches are about PSI.
> > patch 1: Fixed PSI statistics error caused by unzeroed memory
> > in struct psi_group.
> > patch 2 and patch 3 are to clean up some unused functions
> > and parameters.
> >
> > Hao Jia (3):
> > sched/psi: Zero the memory of struct psi_group
> > sched/psi: Remove unused parameter nbytes of psi_trigger_create()
> > sched/psi: Remove redundant cgroup_psi() when !CONFIG_CGROUPS
> >
> > include/linux/cgroup.h | 5 -----
> > include/linux/psi.h | 2 +-
> > kernel/cgroup/cgroup.c | 2 +-
> > kernel/sched/psi.c | 10 +++-------
> > 4 files changed, 5 insertions(+), 14 deletions(-)
>
> Johannes, care to review these patches?
They look good to me.
Thanks!
next prev parent reply other threads:[~2022-08-10 15:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-06 12:05 [PATCH 0/3] sched/psi: psi bug fixes and cleanups Hao Jia
2022-08-06 12:05 ` [PATCH 1/3] sched/psi: Zero the memory of struct psi_group Hao Jia
2022-08-10 15:04 ` Johannes Weiner
2022-08-06 12:05 ` [PATCH 2/3] sched/psi: Remove unused parameter nbytes of psi_trigger_create() Hao Jia
2022-08-10 15:12 ` Johannes Weiner
2022-08-06 12:05 ` [PATCH 3/3] sched/psi: Remove redundant cgroup_psi() when !CONFIG_CGROUPS Hao Jia
2022-08-10 15:13 ` Johannes Weiner
2022-08-06 19:38 ` [PATCH 0/3] sched/psi: psi bug fixes and cleanups Ingo Molnar
2022-08-09 17:37 ` Tejun Heo
2022-08-10 15:13 ` Johannes Weiner [this message]
2022-08-15 20:55 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvPLNNlIyjLXv71v@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=jiahao.os@bytedance.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox