Re: [PATCH v9 1/6] x86/tdx: Add TDX Guest attestation interface driver

Dave Hansen
2022-08-22T21:19:52Z

On 8/18/22 07:18, Borislav Petkov wrote:
>> /* TDX module Call Leaf IDs */
>> #define TDX_GET_INFO 1
>> #define TDX_GET_VEINFO 3
>> @@ -34,6 +39,10 @@
>> #define VE_GET_PORT_NUM(e) ((e) >> 16)
>> #define VE_IS_IO_STRING(e) ((e) & BIT(4))
>>
>> +#define DRIVER_NAME "tdx-guest"
> Just "tdx". When you add another driver, then you can disambiguate.

This actually shows up to apps, though. They'll actually be opening
/dev/tdx. When the other driver comes along, they'll all need to change
to /dev/tdx-guest. That seems a bit unkind to those poor app developers.

BTW, do we consider these kernel names be part of the ABI? Seems like
we should.