Re: [PATCH v9 1/6] x86/tdx: Add TDX Guest attestation interface driver

Sathyanarayanan Kuppuswamy
2022-08-23T20:15:05Z

Hi Boris,

On 8/18/22 7:18 AM, Borislav Petkov wrote:
>> diff --git a/arch/x86/coco/tdx/attest.c b/arch/x86/coco/tdx/attest.c
>> new file mode 100644
>> index 000000000000..46a2f3612753
>> --- /dev/null
>> +++ b/arch/x86/coco/tdx/attest.c
>> @@ -0,0 +1,81 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * attest.c - TDX attestation feature support.
> s/feature //
>
>> + *
>> + * Implements attestation related IOCTL handlers.
>> + *
>> + * Copyright (C) 2022 Intel Corporation
>> + *
>> + */
>> +
>> +#include <linux/mm.h>
>> +#include <linux/io.h>
>> +#include <asm/tdx.h>
>> +
>> +#include "tdx.h"
>> +
>> +/* TDREPORT module call leaf ID */
>> +#define TDX_GET_REPORT 4
> All TDX leaf definitions go to arch/x86/include/asm/shared/tdx.h, for
> example.
>
> Not spread around the tree. There are some in arch/x86/coco/tdx/tdx.c
> too.
>
> In a pre-patch: please pick a fitting header, move them there and keep
> them all there.
>

In v10 of this patch set, this code is moved to coco/tdx/tdx.c and the module
call leaf IDs are grouped together in tdx.c.

Regarding moving the leaf definition to asm/shared, the following patch from
Kirill's unaccepted memory patch set is already doing it. Do you want to me to
leave it to Kirill to handle the cleanup, or submit a new patch here?

https://lore.kernel.org/linux-mm/20220614120231.48165-13-kirill.shutemov@linux.intel.com/

--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer