Re: [PATCH v9 1/6] x86/tdx: Add TDX Guest attestation interface driver

Sathyanarayanan Kuppuswamy
2022-08-24T16:57:07Z

On 8/24/22 8:56 AM, Borislav Petkov wrote:
> On Mon, Aug 22, 2022 at 03:41:00PM -0700, Sathyanarayanan Kuppuswamy wrote:
>> In addition to above, I think there is a possibility to add IOCTL to get
>> storage keys from the ACPI SVKL table. Storage Volume Key Table (SVKL) is
>> used by the VBIOS to share keys required to access encrypted drives. Although
>> we don't have a clear requirement, I suspect that we might add IOCTL for it.
>
> So this all sounds like a single tdx-guest driver to me which services a
> bunch of ioctls... not separate drivers.
>
> Hmm?

Yes. You are right. This is similar to AMD sev-guest driver.

https://github.com/torvalds/linux/blob/master/drivers/virt/coco/sev-guest/sev-guest.c

>

--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer