Re: [PATCH v9 2/6] selftests: tdx: Test GetReport TDX attestation feature

Kai Huang
2022-08-02T00:09:07Z

On Mon, 2022-08-01 at 10:49 -0700, Sathyanarayanan Kuppuswamy wrote:
> >
> > Btw, as it appears you only verified reportdata below, is it worth to have
> > all
> > those data structures (and they are used by hardware but not __packed)?
> > Perhaps
> > a macro to define REPORTDATA offset in TDREPORT is good enough?  Or maybe I
> > am
> > missing something.
>
> I have added these data structs to make it easier for readers to understand
> the contents of the TDREPORT. I thought a simple offset based check would look
> like a magic number. If the maintainers are fine with offset based comparison,
> I am ok with it.

They need to be __packed, at least.

--
Thanks,
-Kai