From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3B3CC19F2A for ; Thu, 11 Aug 2022 09:06:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234906AbiHKJGn (ORCPT ); Thu, 11 Aug 2022 05:06:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234904AbiHKJGh (ORCPT ); Thu, 11 Aug 2022 05:06:37 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EC841C91B; Thu, 11 Aug 2022 02:06:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8C4ECB81E89; Thu, 11 Aug 2022 09:06:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4D40C433D6; Thu, 11 Aug 2022 09:06:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660208792; bh=iRuCN23HjU+/0DgKmO02U4/GO+BUofienWtPcU/NUoE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mNl2/XlJILYOQtpQNmlo/gY7NJ0rhnMzK4ZKqqRMqfzJo3mJa50jIQRvEqdShj8kj KaSu+hujYgRk+SLdxeetMyu8Qfyp+1CKNYL4bZqtcQlAYQGTgaT6p0Sk1JIdwC9lsb o+mhcDtqvvIuzhZLKwt2iCJM9g2lfTXAtwbCvo/I= Date: Thu, 11 Aug 2022 11:06:29 +0200 From: Greg Kroah-Hartman To: Dongliang Mu Cc: Dongliang Mu , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] USB: trancevibrator: simplify tv_probe Message-ID: References: <20220811090213.35899-1-dzm91@hust.edu.cn> <20220811090213.35899-2-dzm91@hust.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220811090213.35899-2-dzm91@hust.edu.cn> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 11, 2022 at 05:02:09PM +0800, Dongliang Mu wrote: > From: Dongliang Mu > > The function tv_probe does not need to invoke kfree when the > allocation fails. So let's simplify the code of tv_probe. > > Signed-off-by: Dongliang Mu > --- > drivers/usb/misc/trancevibrator.c | 11 ++--------- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff --git a/drivers/usb/misc/trancevibrator.c b/drivers/usb/misc/trancevibrator.c > index 55cb63652eda..30d4d774d448 100644 > --- a/drivers/usb/misc/trancevibrator.c > +++ b/drivers/usb/misc/trancevibrator.c > @@ -84,22 +84,15 @@ static int tv_probe(struct usb_interface *interface, > { > struct usb_device *udev = interface_to_usbdev(interface); > struct trancevibrator *dev; > - int retval; > > dev = kzalloc(sizeof(struct trancevibrator), GFP_KERNEL); > - if (!dev) { > - retval = -ENOMEM; > - goto error; > - } > + if (!dev) > + return -ENOMEM; > > dev->udev = usb_get_dev(udev); > usb_set_intfdata(interface, dev); > > return 0; > - > -error: > - kfree(dev); > - return retval; > } > > static void tv_disconnect(struct usb_interface *interface) > -- > 2.35.1 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot