From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7F21C00140 for ; Fri, 12 Aug 2022 09:46:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237933AbiHLJq0 (ORCPT ); Fri, 12 Aug 2022 05:46:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232876AbiHLJqU (ORCPT ); Fri, 12 Aug 2022 05:46:20 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 66F5BA4B0D for ; Fri, 12 Aug 2022 02:46:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660297578; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2c/iImSQTA02RBtmBVV2RGW771GUr2pXHiaSO81S20w=; b=IHmORjdK92XMIvtpgDkxRLhynwSIMUrcXWet14jLOWw11hFUs1Pgh6YqTUmF0vgzC5Acx1 o6Z3hZGSmT6lBOKm27yBfk7gzSIv6ie3Y9slGv12aFy0DVBu9FqpEZHGdP0+019z/gubTK EHKHcM86F4/tRJbheEf7C8VnFIRaKxU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-211-2Wxmoo5wOzabgm-izal5tA-1; Fri, 12 Aug 2022 05:46:15 -0400 X-MC-Unique: 2Wxmoo5wOzabgm-izal5tA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 29815811E75; Fri, 12 Aug 2022 09:46:14 +0000 (UTC) Received: from localhost (ovpn-12-160.pek2.redhat.com [10.72.12.160]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E44A42166B26; Fri, 12 Aug 2022 09:46:12 +0000 (UTC) Date: Fri, 12 Aug 2022 17:46:09 +0800 From: Baoquan He To: Eric DeVolder Cc: linux-kernel@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, ebiederm@xmission.com, dyoung@redhat.com, vgoyal@redhat.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, nramas@linux.microsoft.com, thomas.lendacky@amd.com, robh@kernel.org, efault@gmx.de, rppt@kernel.org, david@redhat.com, sourabhjain@linux.ibm.com, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com Subject: Re: [PATCH v10 1/8] crash: introduce arch/*/asm/crash.h Message-ID: References: <20220721181747.1640-1-eric.devolder@oracle.com> <20220721181747.1640-2-eric.devolder@oracle.com> <52d40562-ee6f-bb89-6d21-2d6baf67053d@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52d40562-ee6f-bb89-6d21-2d6baf67053d@oracle.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/08/22 at 10:18am, Eric DeVolder wrote: > > > On 8/7/22 22:25, Baoquan He wrote: > > Hi Eric, > > > > On 07/21/22 at 02:17pm, Eric DeVolder wrote: > > > The use of __weak is being eliminated within kexec sources. > > > The technique uses macros mapped onto inline functions in > > > order to replace __weak. > > > > > > This patchset was using __weak and so in order to replace > > > __weak, this patch introduces arch/*/asm/crash.h, patterned > > > after how kexec is moving away from __weak and to the macro > > > definitions. > > > > Are you going to replace __weak in kexec of arll ARCHes? I don't see > > your point why all these empty header files are introduced. Wondering > > what's impacted if not adding these empty files? > > Hi Baoquan, > In this patchset, to file include/linux/crash_core.h I added the line #include . > I patterned this after how include/linux/kexec.h does #include . I am sorry, Eric, it looks not so good. I understand you want to pattern asm/kexe.h, but we need consider reality. Introducing a dozen of empty header file and not being able to tell when they will be filled doesn't make sense. Includig where needed is much simpler. I doubt if your way can pass other reviewers' line. Can you reconsider? diff --git a/kernel/crash_core.c b/kernel/crash_core.c index 77f5f3591760..b0577bdcc491 100644 --- a/kernel/crash_core.c +++ b/kernel/crash_core.c @@ -15,6 +15,7 @@ #include #include +#include #include