From: William Breathitt Gray <william.gray@linaro.org>
To: Julien Panis <jpanis@baylibre.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, mranostay@ti.com
Subject: Re: [PATCH v4 2/3] Documentation: ABI: add sysfs-bus-counter-ecap
Date: Sat, 13 Aug 2022 18:47:17 -0400 [thread overview]
Message-ID: <Yvgp9WGcA2fqS1Rm@fedora> (raw)
In-Reply-To: <20220810140724.182389-3-jpanis@baylibre.com>
[-- Attachment #1: Type: text/plain, Size: 3704 bytes --]
On Wed, Aug 10, 2022 at 04:07:23PM +0200, Julien Panis wrote:
> This commit adds an ABI file for TI ECAP used in capture operating mode.
>
> Signed-off-by: Julien Panis <jpanis@baylibre.com>
Hi Julien,
Duplicate ABIs are no longer valid, so we consolidated the Counter sysfs
attributes documentation to a single sysfs-bus-counter file in commit
769841c966fd. You can document the new sysfs attributes you introduce
for the TI eCAP counter driver to that sysfs-bus-counter file as well.
William Breathitt Gray
> ---
> .../ABI/testing/sysfs-bus-counter-ecap | 64 +++++++++++++++++++
> 1 file changed, 64 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-bus-counter-ecap
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-counter-ecap b/Documentation/ABI/testing/sysfs-bus-counter-ecap
> new file mode 100644
> index 000000000000..ca530a6806de
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-bus-counter-ecap
> @@ -0,0 +1,64 @@
> +What: /sys/bus/counter/devices/counter0/signal0/polarity1
> +What: /sys/bus/counter/devices/counter0/signal0/polarity2
> +What: /sys/bus/counter/devices/counter0/signal0/polarity3
> +What: /sys/bus/counter/devices/counter0/signal0/polarity4
> +KernelVersion: 5.19
> +Contact: jpanis@baylibre.com
> +Description:
> + ECAP module includes 4 timestamp capture registers.
> + For all 4 sequenced timestamp capture events (1->2->3->4->1->...),
> + edge polarity can be selected. Then, each capture register can be
> + tuned to capture event by either:
> +
> + - "rising"
> + - "falling"
> +
> + Reading returns current trigger polarity.
> +
> + Writing value before enabling capture sets trigger polarity.
> +
> +What: /sys/bus/counter/devices/counter0/signal0/polarity1_available
> +What: /sys/bus/counter/devices/counter0/signal0/polarity2_available
> +What: /sys/bus/counter/devices/counter0/signal0/polarity3_available
> +What: /sys/bus/counter/devices/counter0/signal0/polarity4_available
> +KernelVersion: 5.19
> +Contact: jpanis@baylibre.com
> +Description:
> + Discrete set of available values for the respective polarity X
> + configuration are listed in this file. Values are delimited by
> + newline characters.
> +
> +What: /sys/bus/counter/devices/counter0/count0/enable
> +KernelVersion: 5.19
> +Contact: jpanis@baylibre.com
> +Description:
> + Whether ECAP is enabled. Valid attribute values are boolean.
> +
> + This attribute is intended to serve as a start/stop mechanism
> + for ECAP.
> +
> +What: /sys/bus/counter/devices/counter0/count0/count
> +KernelVersion: 5.19
> +Contact: jpanis@baylibre.com
> +Description:
> + Read-only attribute that indicates the current base counter value.
> +
> +What: /sys/bus/counter/devices/counter0/count0/capture1
> +What: /sys/bus/counter/devices/counter0/count0/capture2
> +What: /sys/bus/counter/devices/counter0/count0/capture3
> +What: /sys/bus/counter/devices/counter0/count0/capture4
> +KernelVersion: 5.19
> +Contact: jpanis@baylibre.com
> +Description:
> + Read-only attributes that indicate the last timestamp captured
> + for the respective capture X register.
> +
> +What: /sys/bus/counter/devices/counter0/count0/capture1_component_id
> +What: /sys/bus/counter/devices/counter0/count0/capture2_component_id
> +What: /sys/bus/counter/devices/counter0/count0/capture3_component_id
> +What: /sys/bus/counter/devices/counter0/count0/capture4_component_id
> +KernelVersion: 5.19
> +Contact: jpanis@baylibre.com
> +Description:
> + Read-only attributes that indicate the component ID of the
> + respective extension or synapse.
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2022-08-13 22:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 14:07 [PATCH v4 0/3] ECAP support on TI AM62x SoC Julien Panis
2022-08-10 14:07 ` [PATCH v4 1/3] dt-binding: counter: add ti,am62-ecap-capture.yaml Julien Panis
2022-08-10 14:40 ` Krzysztof Kozlowski
2022-08-10 14:07 ` [PATCH v4 2/3] Documentation: ABI: add sysfs-bus-counter-ecap Julien Panis
2022-08-13 22:47 ` William Breathitt Gray [this message]
2022-08-10 14:07 ` [PATCH v4 3/3] counter: capture-tiecap: capture driver support for ECAP Julien Panis
2022-08-14 14:48 ` Jonathan Cameron
2022-08-14 17:03 ` William Breathitt Gray
2022-08-15 11:20 ` William Breathitt Gray
2022-08-16 8:11 ` Julien Panis
2022-08-16 15:22 ` William Breathitt Gray
2022-08-16 7:58 ` Julien Panis
2022-08-16 15:12 ` William Breathitt Gray
2022-08-16 15:28 ` Julien Panis
2022-08-14 18:00 ` [PATCH v4 0/3] ECAP support on TI AM62x SoC William Breathitt Gray
2022-08-16 8:26 ` Julien Panis
2022-08-17 13:48 ` Julien Panis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yvgp9WGcA2fqS1Rm@fedora \
--to=william.gray@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jpanis@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mranostay@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox