From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85143C19F2D for ; Sun, 14 Aug 2022 02:03:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238439AbiHNCCt (ORCPT ); Sat, 13 Aug 2022 22:02:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230381AbiHNCCr (ORCPT ); Sat, 13 Aug 2022 22:02:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0620761D92 for ; Sat, 13 Aug 2022 19:02:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8890060F59 for ; Sun, 14 Aug 2022 02:02:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F09F6C433C1; Sun, 14 Aug 2022 02:02:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660442563; bh=3Xhd2qMStNNb5Ln/IC1tYj590OqHgijGKjY6kdJpxOM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aqQK9izivFDXFa8dAOJReQCRDC8kftOBwATyPbyhWhRN4iAGOv97r3qJH/YSu8pe9 p28oPt1v/RiHYTaperJFBJhXEsZ5+qnyH7fTFHLLrFuxX7z4MgnDCJEW2lEwXzVCQV MoHMqdVFQHL1NJQ/pAElanXxHw0Shj8fZjfEO6Su9Ju4XqMK9AkXLCh1xq2rjhDMue F7wB2+0SjIKz+mt9asv8llqOHHCtRFrp76YM95sWFTiPpBQzRZZsbJJK61UM15x/MC l++e/LwCtMMyBS4by5Me3U6BL2GdUWFiyw7O5mJmRkq71LVI/WBtCqev0tGNwGZiUx 6HhjwG9u2vayw== Date: Sun, 14 Aug 2022 09:53:22 +0800 From: Jisheng Zhang To: Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Alexandre Ghiti , Emil Renner Berthing Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com Subject: Re: [PATCH v6 0/2] use static key to optimize pgtable_l4_enabled Message-ID: References: <20220716115059.3509-1-jszhang@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220716115059.3509-1-jszhang@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 16, 2022 at 07:50:57PM +0800, Jisheng Zhang wrote: > The pgtable_l4|[l5]_enabled check sits at hot code path, performance > is impacted a lot. Since pgtable_l4|[l5]_enabled isn't changed after > boot, so static key can be used to solve the performance issue[1]. > > An unified way static key was introduced in [2], but it only targets > riscv isa extension. We dunno whether SV48 and SV57 will be considered > as isa extension, so the unified solution isn't used for > pgtable_l4[l5]_enabled now. > > patch1 fixes a NULL pointer deference if static key is used a bit earlier. > patch2 uses the static key to optimize pgtable_l4|[l5]_enabled. > > [1] http://lists.infradead.org/pipermail/linux-riscv/2021-December/011164.html > [2] https://lore.kernel.org/linux-riscv/20220517184453.3558-1-jszhang@kernel.org/T/#t Hi Palmer, I see part1 and part2 were sent out... What I can do to make this series merged for 6.0-rc1? I'm afraid this series may miss anothe round of merge window again. Thanks in advance > > Since v5: > - Use DECLARE_STATIC_KEY_FALSE > > Since v4: > - rebased on v5.19-rcN > - collect Reviewed-by tags > - Fix kernel panic issue if SPARSEMEM is enabled by moving the > riscv_finalise_pgtable_lx() after sparse_init() > > Since v3: > - fix W=1 call to undeclared function 'static_branch_likely' error > > Since v2: > - move the W=1 warning fix to a separate patch > - move the unified way to use static key to a new patch series. > > Since v1: > - Add a W=1 warning fix > - Fix W=1 error > - Based on v5.18-rcN, since SV57 support is added, so convert > pgtable_l5_enabled as well. > > Jisheng Zhang (2): > riscv: move sbi_init() earlier before jump_label_init() > riscv: turn pgtable_l4|[l5]_enabled to static key for RV64 > > arch/riscv/include/asm/pgalloc.h | 16 ++++---- > arch/riscv/include/asm/pgtable-32.h | 3 ++ > arch/riscv/include/asm/pgtable-64.h | 60 ++++++++++++++++++--------- > arch/riscv/include/asm/pgtable.h | 5 +-- > arch/riscv/kernel/cpu.c | 4 +- > arch/riscv/kernel/setup.c | 2 +- > arch/riscv/mm/init.c | 64 ++++++++++++++++++----------- > arch/riscv/mm/kasan_init.c | 16 ++++---- > 8 files changed, 104 insertions(+), 66 deletions(-) > > -- > 2.34.1 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv