public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] selftests/sgx: Ignore OpenSSL 3.0 deprecated functions warning
@ 2022-08-12 18:07 Kristen Carlson Accardi
  2022-08-14 19:22 ` Jarkko Sakkinen
  0 siblings, 1 reply; 3+ messages in thread
From: Kristen Carlson Accardi @ 2022-08-12 18:07 UTC (permalink / raw)
  To: linux-kernel, Jarkko Sakkinen, Dave Hansen, Shuah Khan
  Cc: Kristen Carlson Accardi, linux-sgx, linux-kselftest

OpenSSL 3.0 deprecates some of the functions used in the SGX
selftests, causing build errors on new distros. For now ignore
the warnings until support for the functions is no longer
available and mark FIXME so that it can be clear this should
be removed at some point.

Signed-off-by: Kristen Carlson Accardi <kristen@linux.intel.com>
---
 tools/testing/selftests/sgx/sigstruct.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tools/testing/selftests/sgx/sigstruct.c b/tools/testing/selftests/sgx/sigstruct.c
index 50c5ab1aa6fa..a07896a46364 100644
--- a/tools/testing/selftests/sgx/sigstruct.c
+++ b/tools/testing/selftests/sgx/sigstruct.c
@@ -17,6 +17,12 @@
 #include "defines.h"
 #include "main.h"
 
+/*
+ * FIXME: OpenSSL 3.0 has deprecated some functions. For now just ignore
+ * the warnings.
+ */
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+
 struct q1q2_ctx {
 	BN_CTX *bn_ctx;
 	BIGNUM *m;
-- 
2.36.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] selftests/sgx: Ignore OpenSSL 3.0 deprecated functions warning
  2022-08-12 18:07 [PATCH v2] selftests/sgx: Ignore OpenSSL 3.0 deprecated functions warning Kristen Carlson Accardi
@ 2022-08-14 19:22 ` Jarkko Sakkinen
  2022-08-15 22:51   ` Shuah Khan
  0 siblings, 1 reply; 3+ messages in thread
From: Jarkko Sakkinen @ 2022-08-14 19:22 UTC (permalink / raw)
  To: Kristen Carlson Accardi
  Cc: linux-kernel, Dave Hansen, Shuah Khan, linux-sgx, linux-kselftest

On Fri, Aug 12, 2022 at 11:07:13AM -0700, Kristen Carlson Accardi wrote:
> OpenSSL 3.0 deprecates some of the functions used in the SGX
> selftests, causing build errors on new distros. For now ignore
> the warnings until support for the functions is no longer
> available and mark FIXME so that it can be clear this should
> be removed at some point.
> 
> Signed-off-by: Kristen Carlson Accardi <kristen@linux.intel.com>
> ---
>  tools/testing/selftests/sgx/sigstruct.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/tools/testing/selftests/sgx/sigstruct.c b/tools/testing/selftests/sgx/sigstruct.c
> index 50c5ab1aa6fa..a07896a46364 100644
> --- a/tools/testing/selftests/sgx/sigstruct.c
> +++ b/tools/testing/selftests/sgx/sigstruct.c
> @@ -17,6 +17,12 @@
>  #include "defines.h"
>  #include "main.h"
>  
> +/*
> + * FIXME: OpenSSL 3.0 has deprecated some functions. For now just ignore
> + * the warnings.
> + */
> +#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
> +
>  struct q1q2_ctx {
>  	BN_CTX *bn_ctx;
>  	BIGNUM *m;
> -- 
> 2.36.1
> 

Thank you.


Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

BR, Jarkko

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] selftests/sgx: Ignore OpenSSL 3.0 deprecated functions warning
  2022-08-14 19:22 ` Jarkko Sakkinen
@ 2022-08-15 22:51   ` Shuah Khan
  0 siblings, 0 replies; 3+ messages in thread
From: Shuah Khan @ 2022-08-15 22:51 UTC (permalink / raw)
  To: Jarkko Sakkinen, Kristen Carlson Accardi
  Cc: linux-kernel, Dave Hansen, Shuah Khan, linux-sgx, linux-kselftest,
	Shuah Khan

On 8/14/22 1:22 PM, Jarkko Sakkinen wrote:
> On Fri, Aug 12, 2022 at 11:07:13AM -0700, Kristen Carlson Accardi wrote:
>> OpenSSL 3.0 deprecates some of the functions used in the SGX
>> selftests, causing build errors on new distros. For now ignore
>> the warnings until support for the functions is no longer
>> available and mark FIXME so that it can be clear this should
>> be removed at some point.
>>
>> Signed-off-by: Kristen Carlson Accardi <kristen@linux.intel.com>
>> ---
>>   tools/testing/selftests/sgx/sigstruct.c | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/tools/testing/selftests/sgx/sigstruct.c b/tools/testing/selftests/sgx/sigstruct.c
>> index 50c5ab1aa6fa..a07896a46364 100644
>> --- a/tools/testing/selftests/sgx/sigstruct.c
>> +++ b/tools/testing/selftests/sgx/sigstruct.c
>> @@ -17,6 +17,12 @@
>>   #include "defines.h"
>>   #include "main.h"
>>   
>> +/*
>> + * FIXME: OpenSSL 3.0 has deprecated some functions. For now just ignore
>> + * the warnings.
>> + */
>> +#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
>> +
>>   struct q1q2_ctx {
>>   	BN_CTX *bn_ctx;
>>   	BIGNUM *m;
>> -- 
>> 2.36.1
>>
> 
> Thank you.
> 
> 
> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> BR, Jarkko
> 

Thank you both.

Applied for rc2/3

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-08-16  5:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-12 18:07 [PATCH v2] selftests/sgx: Ignore OpenSSL 3.0 deprecated functions warning Kristen Carlson Accardi
2022-08-14 19:22 ` Jarkko Sakkinen
2022-08-15 22:51   ` Shuah Khan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox