Re: [PATCH v1 0/9] fw_devlink improvements

Alexander Stein
2022-08-16T09:04:51Z

Hello Saravana,

Am Montag, 15. August 2022, 21:17:36 CEST schrieb Saravana Kannan:
> On Mon, Aug 15, 2022 at 5:39 AM Alexander Stein
>
> <alexander.stein@ew.tq-group.com> wrote:
> > Hello Saravana,
> >
> > Am Mittwoch, 10. August 2022, 08:00:29 CEST schrieb Saravana Kannan:
> > > Alexander,
> > >
> > > This should fix your issue where the power domain device not having a
> > > compatible property. Can you give it a shot please?
> >
> > thanks for the update. Unfortunately this does not work:
> > > [ 0.774838] PM: Added domain provider from /soc@0/bus@30000000/
> >
> > gpc@303a0000/pgc/power-domain@0
> >
> > > [ 0.775100] imx-pgc imx-pgc-domain.1: __genpd_dev_pm_attach() failed
> > > to
> >
> > find PM domain: -2
> >
> > > [ 0.775324] PM: Added domain provider from /soc@0/bus@30000000/
> >
> > gpc@303a0000/pgc/power-domain@2
> >
> > > [ 0.775601] PM: Added domain provider from /soc@0/bus@30000000/
> >
> > gpc@303a0000/pgc/power-domain@3
> >
> > > [ 0.775842] PM: Added domain provider from /soc@0/bus@30000000/
> >
> > gpc@303a0000/pgc/power-domain@4
> >
> > > [ 0.776642] PM: Added domain provider from /soc@0/bus@30000000/
> >
> > gpc@303a0000/pgc/power-domain@7
> >
> > > [ 0.776897] PM: Added domain provider from /soc@0/bus@30000000/
> >
> > gpc@303a0000/pgc/power-domain@8
> >
> > > [ 0.777158] PM: Added domain provider from /soc@0/bus@30000000/
> >
> > gpc@303a0000/pgc/power-domain@9
> >
> > > [ 0.777405] PM: Added domain provider from /soc@0/bus@30000000/
> >
> > gpc@303a0000/pgc/power-domain@a
> >
> > > [ 0.779342] genpd genpd:0:38320000.blk-ctrl: __genpd_dev_pm_attach()
> >
> > failed to find PM domain: -2
> >
> > > [ 0.779422] imx8m-blk-ctrl 38320000.blk-ctrl: error -ENODEV: failed
> > > to
> >
> > attach power domain "bus"
> >
> > > [ 0.848785] etnaviv-gpu 38000000.gpu: __genpd_dev_pm_attach() failed
> > > to
> >
> > find PM domain: -2
> >
> > > [ 1.114220] pfuze100-regulator 0-0008: Full layer: 2, Metal layer: 1
> > > [ 1.122267] pfuze100-regulator 0-0008: FAB: 0, FIN: 0
> > > [ 1.132970] pfuze100-regulator 0-0008: pfuze100 found.
> > > [ 1.157011] imx-gpcv2 303a0000.gpc: Failed to create device link with
> >
> > 0-0008
> >
> > > [ 1.164094] imx-gpcv2 303a0000.gpc: Failed to create device link with
> >
> > 0-0008
> >
> > The required power-supply for the power domains is still not yet
> > available.
> > Does this series require some other patches as well?
>
> Ah sorry, yeah, this needs additional patches. The one I gave in the
> other thread when I debugged this and I also noticed another issue.
> Here's the combined diff of what's needed. Can you add this on top of
> the series and test it?
>
> diff --git a/drivers/irqchip/irq-imx-gpcv2.c
> b/drivers/irqchip/irq-imx-gpcv2.c index b9c22f764b4d..8a0e82067924 100644
> --- a/drivers/irqchip/irq-imx-gpcv2.c
> +++ b/drivers/irqchip/irq-imx-gpcv2.c
> @@ -283,6 +283,7 @@ static int __init imx_gpcv2_irqchip_init(struct
> device_node *node,
> * later the GPC power domain driver will not be skipped.
> */
> of_node_clear_flag(node, OF_POPULATED);
> + fwnode_dev_initialized(domain->fwnode, false);
> return 0;
> }
>
> diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c
> index 6383a4edc360..181fbfe5bd4d 100644
> --- a/drivers/soc/imx/gpcv2.c
> +++ b/drivers/soc/imx/gpcv2.c
> @@ -1513,6 +1513,7 @@ static int imx_gpcv2_probe(struct platform_device
> *pdev)
>
> pd_pdev->dev.parent = dev;
> pd_pdev->dev.of_node = np;
> + pd_pdev->dev.fwnode = of_fwnode_handle(np);
>
> ret = platform_device_add(pd_pdev);
> if (ret) {
>
> With this patch, I'd really expect the power domain dependency to be
> handled correctly.

I was out of office so I didn't keep track of any dependencies, sorry.
With these 2 changes above my power domain problem is fixed!

Thanks
Alexander