From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF481C25B0E for ; Mon, 15 Aug 2022 17:19:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231270AbiHORTE (ORCPT ); Mon, 15 Aug 2022 13:19:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229582AbiHORTB (ORCPT ); Mon, 15 Aug 2022 13:19:01 -0400 Received: from zeeaster.vergenet.net (zeeaster.vergenet.net [206.189.110.174]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A21627CF6 for ; Mon, 15 Aug 2022 10:18:59 -0700 (PDT) Received: from madeliefje.horms.nl (2a02-a44a-2918-403-201-8eff-fe22-8fea.fixed6.kpn.net [IPv6:2a02:a44a:2918:403:201:8eff:fe22:8fea]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by zeeaster.vergenet.net (Postfix) with ESMTPSA id 9DBEE20101; Mon, 15 Aug 2022 17:18:57 +0000 (UTC) Received: by madeliefje.horms.nl (Postfix, from userid 7100) id 6E5E6D3C; Mon, 15 Aug 2022 18:18:57 +0100 (BST) Date: Mon, 15 Aug 2022 18:18:57 +0100 From: Simon Horman To: Bjorn Helgaas Cc: Liu Song , bhelgaas@google.com, pablo@netfilter.org, davem@davemloft.net, nathan@kernel.org, apw@canonical.com, joe@perches.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Kconfig: eliminate abnormal characters displayed under menuconfig Message-ID: References: <1659435153-119538-1-git-send-email-liusong@linux.alibaba.com> <20220809025147.GA1264335@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220809025147.GA1264335@bhelgaas> Organisation: Horms Solutions BV X-Virus-Scanned: clamav-milter 0.103.6 at zeeaster X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 08, 2022 at 09:51:47PM -0500, Bjorn Helgaas wrote: > On Tue, Aug 02, 2022 at 06:12:33PM +0800, Liu Song wrote: > > From: Liu Song > > > > Use "find ./linux/* | grep Kconfig | xargs file | grep UTF", can find > > files with utf-8 encoded characters, these files will display garbled > > characters in menuconfig, except for characters with special meanings > > that cannot be modified, modify the characters with obvious errors to > > eliminate the wrong display under meunconfig. > > > > Signed-off-by: Liu Song > > Suggested-by: Bjorn Helgaas > > I did suggest fixing everything at once. But I think there are > actually two problems here. The first is that some are just wrong, > e.g., drivers/pci/Kconfig using CYRILLIC SMALL LETTER DZE instead of > "s", or net/netfilter/ipvs/Kconfig using NO-BREAK SPACE for no good > reason. > > arch/Kconfig looks like it's using RIGHT SINGLE QUOTATION MARK instead > of the basic APOSTROPHE. That one is debatable; I think it's fair to > argue that RIGHT SINGLE QUOTATION MARK would be preferred if rendered > correctly. > > The second problem is that I think menuconfig doesn't handle UTF-8 > correctly. For example, in a gnome terminal with the default > LC_ALL=en_US.UTF-8, these look fine: > > $ grep -A10 MTD_SPI_NOR_USE_4K_SECTORS drivers/mtd/spi-nor/Kconfig > ... > 64 KiB block instead of 16 × 4 KiB sectors. > > $ grep -A1 MTD_NAND_CAFE drivers/mtd/nand/raw/Kconfig > config MTD_NAND_CAFE > tristate "OLPC CAFÉ NAND controller" > > But when menuconfig in the same terminal displays that same text, it > looks like "16 ~W 4 KiB sectors" and "OLPC CAF ~I NAND". > > On the other hand, gconfig and xconfig do render these correctly. So > I think there's something wrong with UTF-8 in menuconfig, and we > should fix that as well. > > Anyway, I'm fine with this patch as far as it goes: > > Acked-by: Bjorn Helgaas IPVS portion: Acked-by: Simon Horman