From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3281EC28B2B for ; Tue, 16 Aug 2022 15:22:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235931AbiHPPWz (ORCPT ); Tue, 16 Aug 2022 11:22:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236072AbiHPPWw (ORCPT ); Tue, 16 Aug 2022 11:22:52 -0400 Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A5837FE7E for ; Tue, 16 Aug 2022 08:22:51 -0700 (PDT) Received: by mail-qk1-x729.google.com with SMTP id t11so8337590qkt.6 for ; Tue, 16 Aug 2022 08:22:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=jT6iuOkP/KCXgNgpKbeKBLLjw+3KLDIzLYKXQZiNLYs=; b=MiDRnXjwdBKgIi27CYdBNeS5oDJfFwAd2TBir5Ho8jleWQdN0Ap6ezN9+AHlOE2+Qr 7x30r4gzLKCnth/jkAO66P9EAT3CyPnTPKt2/ksS3wgcgScs7tTd6S/1oVau/Gc5R0o/ dsenaC5o/iC6GztkI3eQ6oA5FVxqTbZ1uV9+NcjEtIDXWekgYPkz/mx8/qD3fzZefhKZ TTdHDEMkvwnQNKkA04NB1GCv8T2kpo0Gjvleiltk3T4rgsyYdv+eFuEFJGmlRvyycAiR ZZxZh0HQDAv1LNY6uwvN6xoQYLkutC73klWNLVf9w/k44pRn967zmI0qLdAXGQEN3C5E 7t3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=jT6iuOkP/KCXgNgpKbeKBLLjw+3KLDIzLYKXQZiNLYs=; b=0Okk41AgiH+nuv4r0N2mHUMbdHrQRp1i9EtaIpd7AKPJ3fqMQJhIe75uyAaff40837 Zl7Y6qMtyKNI39UpW1v9auonm3GsMyIdQtyVNcD5AFy11TK7Oyo8QVLj/KLs/n2YFZmA NUAtsQajVG+Awh4h1NiN+shgmXHs/slFgEfJssuuwY9z15yMfNiuJ0+CWitEPMOeIQR5 /WROgwSXpsVGutzANneH/LtKlTIRBZKffiO51PgGjDp5LJ2GwDUBTc2IuuLGzkwJF66V CRxW9ZsjErkve1evd+7TKyJisIrOlM73YKtostaQEbnAMwMQnhP0rRAIex+rGCG+SbW1 5BVw== X-Gm-Message-State: ACgBeo1EQTQKkvbCQjq/KlAeZL434zpUNbaukDOmQsmgCWirv0yb8rsP O8FyhPr/mlRsmsJL2RP29i6Q3Q== X-Google-Smtp-Source: AA6agR5DT8IuYw0mAD2K36WSO8rzZ7Hkyf6rxMM9+v0nWk5fHU2EhOkFFG6BkRrCB09Z4KG4dJZ7QA== X-Received: by 2002:a05:620a:1a9b:b0:6a6:d3f6:5c97 with SMTP id bl27-20020a05620a1a9b00b006a6d3f65c97mr15175583qkb.225.1660663370607; Tue, 16 Aug 2022 08:22:50 -0700 (PDT) Received: from fedora ([23.82.142.208]) by smtp.gmail.com with ESMTPSA id v3-20020a05620a440300b006b945519488sm9623161qkp.88.2022.08.16.08.22.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Aug 2022 08:22:50 -0700 (PDT) Date: Tue, 16 Aug 2022 11:22:48 -0400 From: William Breathitt Gray To: Julien Panis Cc: vilhelm.gray@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, mranostay@ti.com Subject: Re: [PATCH v4 3/3] counter: capture-tiecap: capture driver support for ECAP Message-ID: References: <20220810140724.182389-1-jpanis@baylibre.com> <20220810140724.182389-4-jpanis@baylibre.com> <0730c493-b49f-02f5-c0e7-999d5871dc4a@baylibre.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="joL9fFR8nEuznmrQ" Content-Disposition: inline In-Reply-To: <0730c493-b49f-02f5-c0e7-999d5871dc4a@baylibre.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --joL9fFR8nEuznmrQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 16, 2022 at 10:11:35AM +0200, Julien Panis wrote: > On 15/08/2022 13:20, William Breathitt Gray wrote: > > On Sun, Aug 14, 2022 at 01:03:48PM -0400, William Breathitt Gray wrote: > > > On Wed, Aug 10, 2022 at 04:07:24PM +0200, Julien Panis wrote: > > > > +static int ecap_cnt_function_read(struct counter_device *counter, > > > > + struct counter_count *count, > > > > + enum counter_function *function) > > > > +{ > > > > + *function =3D COUNTER_FUNCTION_INCREASE; > > > > + > > > > + return 0; > > > > +} > > > > + > > > > +static int ecap_cnt_action_read(struct counter_device *counter, > > > > + struct counter_count *count, > > > > + struct counter_synapse *synapse, > > > > + enum counter_synapse_action *action) > > > > +{ > > > > + *action =3D COUNTER_SYNAPSE_ACTION_BOTH_EDGES; > > > > + > > > > + return 0; > > > > +} > > > Right now you have a Signal defined for the ECAPSIG line, but there is > > > at least one more relevant Signal to define: the clock updating ECAPC= NT. > > > The Synapse action of COUNTER_SYNAPSE_ACTION_BOTH_EDGES is for that > > > clock Signal, but for the ECAPSIG Signal you will need to report a > > > Synapse action based on the polarity of the next capture (i.e. whether > > > high or low). > > I need to make a correction here. IIUC, the ECAPSIG signal doesn't > > affect the count value of ECAPCNT (ECAPSIG only triggers the captures), > > so the Synapse action for ECAPSIG should always be > > COUNTER_SYNAPSE_ACTION_NONE. You don't need to account for the capture > > polarities because they're not relevant in this particular situation: > > ECAPSIG doesn't trigger the ECAPCNT count function. > >=20 > > William Breathitt Gray >=20 > It appears to me that you spoke about TSCNT register content (32 bits). S= o, > you were > not talking about the Mod4 counter (2 bits). > Do you confirm that ? Yes, I meant the TSCNT register. Sorry about that! The Counter subsystem is providing an abstraction for users, so although the ECAP pin signal is serving physically on the device as a clock for the Mod4 counter, it also serves the TSCNT counter in an abstract sense as the trigger signal to capture the TSCNT value. The Counter subsystem paradigm allows you to define these abstract relationships between Counts and Signals as Synapses. William Breathitt Gray --joL9fFR8nEuznmrQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCYvu2SAAKCRC1SFbKvhIj KzqtAQDggpFX/Wl1JrWkKSL6rjcqDHr/JKzg+czwZHsmvq/3jAEAtHTNxOOtJCDs yDgJcJb8m2mnG3KOYttsRGkFaiZM3Qk= =Aa8N -----END PGP SIGNATURE----- --joL9fFR8nEuznmrQ--