From: Tejun Heo <tj@kernel.org>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: mkoutny@suse.com, axboe@kernel.dk, ming.lei@redhat.com,
cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, yukuai3@huawei.com,
yi.zhang@huawei.com
Subject: Re: [PATCH v7 3/9] blk-throttle: factor out code to calculate ios/bytes_allowed
Date: Tue, 16 Aug 2022 09:47:11 -1000 [thread overview]
Message-ID: <Yvv0P5YXf2HdEC1d@slm.duckdns.org> (raw)
In-Reply-To: <20220802140415.2960284-4-yukuai1@huaweicloud.com>
On Tue, Aug 02, 2022 at 10:04:09PM +0800, Yu Kuai wrote:
> +static bool tg_with_in_iops_limit(struct throtl_grp *tg, struct bio *bio,
> + u32 iops_limit, unsigned long *wait)
While at it, can you please rename these functions to tg_within_iops_limit?
"within" is a single word. Other than that,
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2022-08-16 19:47 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 14:04 [PATCH v7 0/9] bugfix and cleanup for blk-throttle Yu Kuai
2022-08-02 14:04 ` [PATCH v7 1/9] blk-throttle: fix that io throttle can only work for single bio Yu Kuai
2022-08-16 19:37 ` Tejun Heo
2022-08-17 1:13 ` Yu Kuai
2022-08-17 17:50 ` Tejun Heo
2022-08-18 1:23 ` Yu Kuai
2022-08-22 3:06 ` Yu Kuai
2022-08-22 7:25 ` Tejun Heo
2022-08-22 7:44 ` Yu Kuai
2022-08-02 14:04 ` [PATCH v7 2/9] blk-throttle: prevent overflow while calculating wait time Yu Kuai
2022-08-02 14:04 ` [PATCH v7 3/9] blk-throttle: factor out code to calculate ios/bytes_allowed Yu Kuai
2022-08-16 19:47 ` Tejun Heo [this message]
2022-08-17 1:32 ` Yu Kuai
2022-08-02 14:04 ` [PATCH v7 4/9] blk-throttle: fix io hung due to configuration updates Yu Kuai
2022-08-16 20:01 ` Tejun Heo
2022-08-17 1:30 ` Yu Kuai
2022-08-17 17:52 ` Tejun Heo
2022-08-18 1:16 ` Yu Kuai
2022-08-19 17:33 ` Tejun Heo
2022-08-02 14:04 ` [PATCH v7 5/9] blk-throttle: improve handling of re-entered bio for bps limit Yu Kuai
2022-08-16 20:02 ` Tejun Heo
2022-08-02 14:04 ` [PATCH v7 6/9] blk-throttle: use 'READ/WRITE' instead of '0/1' Yu Kuai
2022-08-16 20:03 ` Tejun Heo
2022-08-17 1:33 ` Yu Kuai
2022-08-02 14:04 ` [PATCH v7 7/9] blk-throttle: calling throtl_dequeue/enqueue_tg in pairs Yu Kuai
2022-08-02 14:04 ` [PATCH v7 8/9] blk-throttle: cleanup tg_update_disptime() Yu Kuai
2022-08-16 20:09 ` Tejun Heo
2022-08-17 1:38 ` Yu Kuai
2022-08-02 14:04 ` [PATCH v7 9/9] blk-throttle: clean up flag 'THROTL_TG_PENDING' Yu Kuai
2022-08-16 20:14 ` Tejun Heo
2022-08-17 1:45 ` Yu Kuai
2022-08-17 17:54 ` Tejun Heo
2022-08-18 9:29 ` Yu Kuai
2022-08-19 17:35 ` Tejun Heo
2022-08-13 5:59 ` [PATCH v7 0/9] bugfix and cleanup for blk-throttle Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yvv0P5YXf2HdEC1d@slm.duckdns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=mkoutny@suse.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox