From: Al Viro <viro@zeniv.linux.org.uk>
To: Paul Lemmermann <thepaulodoom@thepaulodoom.com>
Cc: arnd@arndb.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] improve the kernel quality and reduce the amount of BS patches
Date: Wed, 17 Aug 2022 03:18:04 +0100 [thread overview]
Message-ID: <YvxP3LrvHLhFClBd@ZenIV> (raw)
In-Reply-To: <YvxNvpF7n1VqNnbD@ZenIV>
On Wed, Aug 17, 2022 at 03:09:02AM +0100, Al Viro wrote:
> this idiocy has gone too far
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Seriously, folks - the stream of patches with no better
explanations than "The Most Holy checkpatch.pl Says So, Must Appease
The Spirits" ought to stop.
If you are changing something, take care to explain _why_
is the change made. Reference to a tool that has pointed you
towards the location you are changing does not replace that.
checkpatch.pl is a script. A dumb one. It's a bunch of heuristics
that correlate with code being potentially fishy and worth looking
into; those are occasionally useful, but it's not an oracle.
next prev parent reply other threads:[~2022-08-17 2:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 1:35 [PATCH] drivers: char: mem: changed 'unsigned' to 'unsigned int' Paul Lemmermann
2022-08-17 2:09 ` [PATCH] improve the kernel quality and reduce the amount of BS patches Al Viro
2022-08-17 2:18 ` Al Viro [this message]
2022-08-17 2:29 ` Randy Dunlap
2022-08-18 5:48 ` Joe Perches
2022-08-18 14:52 ` [PATCH] drivers: char: mem: changed 'unsigned' to 'unsigned int' Greg KH
2022-08-19 1:52 ` Paul Lemmermann
2022-08-21 8:35 ` Greg KH
2022-08-21 15:49 ` ThePaulODoom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvxP3LrvHLhFClBd@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thepaulodoom@thepaulodoom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox