From: Al Viro <viro@zeniv.linux.org.uk>
To: Christian Brauner <brauner@kernel.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Dongliang Mu" <mudongliangabcd@gmail.com>,
"Dongliang Mu" <dzm91@hust.edu.cn>,
"Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Martijn Coenen" <maco@android.com>,
"Joel Fernandes" <joel@joelfernandes.org>,
"Carlos Llamas" <cmllamas@google.com>,
"Suren Baghdasaryan" <surenb@google.com>,
"Kees Cook" <keescook@chromium.org>,
syzkaller <syzkaller@googlegroups.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] binderfs: rework superblock destruction
Date: Wed, 17 Aug 2022 14:59:02 +0100 [thread overview]
Message-ID: <Yvz0JkdxXwY8uDyT@ZenIV> (raw)
In-Reply-To: <20220817130306.96978-1-brauner@kernel.org>
On Wed, Aug 17, 2022 at 03:03:06PM +0200, Christian Brauner wrote:
> +static void binderfs_kill_super(struct super_block *sb)
> +{
> + struct binderfs_info *info = sb->s_fs_info;
> +
> + if (info && info->ipc_ns)
> + put_ipc_ns(info->ipc_ns);
> +
> + kfree(info);
> + kill_litter_super(sb);
> +}
Other way round, please - shut the superblock down, *then*
free the objects it'd been using. IOW,
struct binderfs_info *info = sb->s_fs_info;
kill_litter_super(sb);
if (info && info->ipc_ns)
put_ipc_ns(info->ipc_ns);
kfree(info);
next prev parent reply other threads:[~2022-08-17 13:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 13:21 [PATCH] drivers: binderfs: fix memory leak in binderfs_fill_super Dongliang Mu
2022-08-12 13:41 ` Christian Brauner
2022-08-12 13:48 ` Dongliang Mu
2022-08-12 14:18 ` Christian Brauner
2022-08-15 0:59 ` Dongliang Mu
2022-08-12 13:41 ` Greg Kroah-Hartman
2022-08-12 13:56 ` Dongliang Mu
2022-08-12 14:02 ` Dongliang Mu
2022-08-12 14:09 ` Greg Kroah-Hartman
2022-08-12 14:24 ` Christian Brauner
2022-08-12 14:32 ` Greg Kroah-Hartman
2022-08-15 1:46 ` Al Viro
2022-08-15 1:48 ` Al Viro
2022-08-15 8:47 ` Christian Brauner
2022-08-17 11:43 ` Greg Kroah-Hartman
2022-08-17 13:03 ` [PATCH] binderfs: rework superblock destruction Christian Brauner
2022-08-17 13:59 ` Al Viro [this message]
2022-08-17 14:01 ` Christian Brauner
2022-08-17 14:19 ` Al Viro
2022-08-17 14:32 ` Al Viro
2022-08-17 15:05 ` Christian Brauner
2022-08-17 14:51 ` Christian Brauner
2022-08-17 15:21 ` Al Viro
2022-08-17 15:24 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yvz0JkdxXwY8uDyT@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=arve@android.com \
--cc=brauner@kernel.org \
--cc=cmllamas@google.com \
--cc=dzm91@hust.edu.cn \
--cc=gregkh@linuxfoundation.org \
--cc=joel@joelfernandes.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=mudongliangabcd@gmail.com \
--cc=surenb@google.com \
--cc=syzkaller@googlegroups.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox