From: Ido Schimmel <idosch@nvidia.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: rafael@kernel.org, linux-pm@vger.kernel.org, vadimp@mellanox.com,
davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, vadimp@nvidia.com,
petrm@nvidia.com, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com
Subject: Re: [PATCH v3 2/2] Revert "mlxsw: core: Add the hottest thermal zone detection"
Date: Wed, 17 Aug 2022 17:36:56 +0300 [thread overview]
Message-ID: <Yvz9CIelQSbGuqCg@shredder> (raw)
In-Reply-To: <20220817130227.2268127-2-daniel.lezcano@linaro.org>
On Wed, Aug 17, 2022 at 03:02:27PM +0200, Daniel Lezcano wrote:
> @@ -285,10 +254,8 @@ static int mlxsw_thermal_get_temp(struct thermal_zone_device *tzdev,
> dev_err(dev, "Failed to query temp sensor\n");
> return err;
> }
> +
Unnecessary blank line
> mlxsw_reg_mtmp_unpack(mtmp_pl, &temp, NULL, NULL, NULL, NULL);
> - if (temp > 0)
> - mlxsw_thermal_tz_score_update(thermal, tzdev, thermal->trips,
> - temp);
>
> *p_temp = temp;
> return 0;
> @@ -349,22 +316,6 @@ static int mlxsw_thermal_set_trip_hyst(struct thermal_zone_device *tzdev,
> return 0;
> }
[...]
> @@ -680,6 +623,7 @@ mlxsw_thermal_module_tz_init(struct mlxsw_thermal_module *module_tz)
> MLXSW_THERMAL_TRIP_MASK,
> module_tz,
> &mlxsw_thermal_module_ops,
> +
Likewise
> &mlxsw_thermal_params,
> 0,
> module_tz->parent->polling_delay);
> --
> 2.34.1
>
next prev parent reply other threads:[~2022-08-17 14:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 13:02 [PATCH v3 1/2] Revert "mlxsw: core: Use different get_trend() callbacks for different thermal zones" Daniel Lezcano
2022-08-17 13:02 ` [PATCH v3 2/2] Revert "mlxsw: core: Add the hottest thermal zone detection" Daniel Lezcano
2022-08-17 14:36 ` Ido Schimmel [this message]
2022-08-17 14:32 ` [PATCH v3 1/2] Revert "mlxsw: core: Use different get_trend() callbacks for different thermal zones" Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yvz9CIelQSbGuqCg@shredder \
--to=idosch@nvidia.com \
--cc=daniel.lezcano@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=rafael@kernel.org \
--cc=vadimp@mellanox.com \
--cc=vadimp@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox