Re: [PATCH v6 5/5] vfio/pci: Implement VFIO_DEVICE_FEATURE_LOW_POWER_ENTRY_WITH_WAKEUP

Jason Gunthorpe
2022-08-17T13:53:31Z

On Wed, Aug 17, 2022 at 10:43:23AM +0530, Abhishek Sahu wrote:

> +static int
> +vfio_pci_core_pm_entry_with_wakeup(struct vfio_device *device, u32 flags,
> + void __user *arg, size_t argsz)

This should be
struct vfio_device_low_power_entry_with_wakeup __user *arg

> @@ -1336,6 +1389,9 @@ int vfio_pci_core_ioctl_feature(struct vfio_device *device, u32 flags,
> return vfio_pci_core_feature_token(device, flags, arg, argsz);
> case VFIO_DEVICE_FEATURE_LOW_POWER_ENTRY:
> return vfio_pci_core_pm_entry(device, flags, arg, argsz);
> + case VFIO_DEVICE_FEATURE_LOW_POWER_ENTRY_WITH_WAKEUP:
> + return vfio_pci_core_pm_entry_with_wakeup(device, flags,
> + arg, argsz);
> case VFIO_DEVICE_FEATURE_LOW_POWER_EXIT:
> return vfio_pci_core_pm_exit(device, flags, arg, argsz);

Best to keep these ioctls sorted

Jason