From: Matthias Kaehlcke <mka@chromium.org>
To: Hu Xiaoying <huxiaoying@kylinos.cn>
Cc: stern@rowland.harvard.edu, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] usb: Improves USB2.0 write performance.
Date: Wed, 31 Aug 2022 14:35:36 -0700 [thread overview]
Message-ID: <Yw/UKNu0++5MtvbK@google.com> (raw)
In-Reply-To: <20220831015624.1119578-1-huxiaoying@kylinos.cn>
On Wed, Aug 31, 2022 at 09:56:24AM +0800, Hu Xiaoying wrote:
> Subject: [PATCH v4] usb: Improves USB2.0 write performance.
Virtually everyone who sees this will think that this patch improves
USB 2.0 write performance in general, which isn't the case.
Instead the subject could be something like:
USB: storage: Add ASUS <model> to IGNORE_UAS
> USB external storage device(0x0b05:1932), use gnome-disk-utility tools
> to test usb write < 30MB/s.
> if does not to load module of uas for this device, can increase the
> write speed from 20MB/s to >40MB/s.
>
> Signed-off-by: Hu Xiaoying <huxiaoying@kylinos.cn>
> ---
> change for v4
> - Update two email addresses to be the same.
> change for v3
> - Does not send html mail to the mailing lists.
> - Update patch, which sorted by vendor ID and product ID.
> - Modify discription, correct some english words.
> change for v2
> - Update discription for patch.
> ---
> drivers/usb/storage/unusual_uas.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
> index 4051c8cd0cd8..23ab3b048d9b 100644
> --- a/drivers/usb/storage/unusual_uas.h
> +++ b/drivers/usb/storage/unusual_uas.h
> @@ -62,6 +62,13 @@ UNUSUAL_DEV(0x0984, 0x0301, 0x0128, 0x0128,
> USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> US_FL_IGNORE_UAS),
>
> +/* Reported-by: Tom Hu <huxiaoying@kylinos.cn> */
> +UNUSUAL_DEV(0x0b05, 0x1932, 0x0000, 0x9999,
> + "ASUS",
> + "External HDD",
> + USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> + US_FL_IGNORE_UAS),
> +
> /* Reported-by: David Webb <djw@noc.ac.uk> */
> UNUSUAL_DEV(0x0bc2, 0x331a, 0x0000, 0x9999,
> "Seagate",
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-08-31 21:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 1:56 [PATCH v4] usb: Improves USB2.0 write performance Hu Xiaoying
2022-08-31 2:01 ` Alan Stern
2022-08-31 21:35 ` Matthias Kaehlcke [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-08-31 1:52 Hu Xiaoying
2022-08-31 1:39 Hu Xiaoying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yw/UKNu0++5MtvbK@google.com \
--to=mka@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=huxiaoying@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox