From: Mark Brown <broonie@kernel.org>
To: Steve Lee <steve.lee.analog@gmail.com>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
krzk@kernel.org, ryans.lee@analog.com
Subject: Re: [PATCH] ASoC: max98390: Remove unnecessary amp on/off conrtol
Date: Wed, 31 Aug 2022 17:36:26 +0100 [thread overview]
Message-ID: <Yw+OCnOgYUOWdIEx@sirena.org.uk> (raw)
In-Reply-To: <20220826023504.6183-1-steve.lee.analog@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 483 bytes --]
On Fri, Aug 26, 2022 at 11:35:04AM +0900, Steve Lee wrote:
> The Amp is already control in userspace before trigger calibrate function.
> Remove unnecessary control in calibrate function.
I can't see anything which ensures that this is the case? Should there
be a check which returns an error if the output is not enabled, or
should the function check the current state and preserve it at the end?
I can see that this would fix problems with it being disabled when
callibrating.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-08-31 16:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 2:35 [PATCH] ASoC: max98390: Remove unnecessary amp on/off conrtol Steve Lee
2022-08-31 16:36 ` Mark Brown [this message]
2022-09-01 5:57 ` Lee Steve
2022-09-01 10:54 ` Mark Brown
2022-09-06 5:17 ` Lee Steve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yw+OCnOgYUOWdIEx@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=ryans.lee@analog.com \
--cc=steve.lee.analog@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox