From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: LKML <linux-kernel@vger.kernel.org>,
"DRI Development" <dri-devel@lists.freedesktop.org>,
"Daniel Vetter" <daniel.vetter@intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Tetsuo Handa" <penguin-kernel@i-love.sakura.ne.jp>,
"Xuezhi Zhang" <zhangxuezhi1@coolpad.com>,
"Yangxi Xiang" <xyangxi5@gmail.com>,
"nick black" <dankamongmen@gmail.com>,
"Petr Mladek" <pmladek@suse.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Luis Chamberlain" <mcgrof@kernel.org>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
"Marco Elver" <elver@google.com>,
"John Ogness" <john.ogness@linutronix.de>,
"David Gow" <davidgow@google.com>,
tangmeng <tangmeng@uniontech.com>,
"Tiezhu Yang" <yangtiezhu@loongson.cn>,
"Chris Wilson" <chris@chris-wilson.co.uk>
Subject: Re: [PATCH] kernel/panic: Drop unblank_screen call
Date: Wed, 31 Aug 2022 14:41:14 +0200 [thread overview]
Message-ID: <Yw9W6qYo6Acg7rad@linutronix.de> (raw)
In-Reply-To: <20220830145004.430545-1-daniel.vetter@ffwll.ch>
On 2022-08-30 16:50:04 [+0200], Daniel Vetter wrote:
> Long story short, I have no idea why the direct call to unblank_screen
> survived for so long (the infrastructure to do it properly existed for
> years), nor why it wasn't removed when the console_unblank() call was
> finally added. But it makes a ton more sense to finally do that than
> not - it's just better encapsulation to go through the console
> functions instead of doing a direct call, so let's dare. Plus it
> really does not make much sense to call the only unblank
> implementation there is twice, once without, and once with appropriate
> locking.
Yup, calling it twice is redundant.
The only difference I see is that the console implementation relies on
CONFIG_VT_CONSOLE while the former relied only on CONFIG_VT. There
should be no console output without CONFIG_VT_CONSOLE so no need to
unblank it.
Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Sebastian
next prev parent reply other threads:[~2022-08-31 12:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 14:50 [PATCH] kernel/panic: Drop unblank_screen call Daniel Vetter
2022-08-31 12:41 ` Sebastian Andrzej Siewior [this message]
2022-09-01 11:35 ` Petr Mladek
2022-09-01 19:26 ` Daniel Vetter
2022-09-02 13:29 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yw9W6qYo6Acg7rad@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dankamongmen@gmail.com \
--cc=davidgow@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=elver@google.com \
--cc=gpiccoli@igalia.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=pmladek@suse.com \
--cc=tangmeng@uniontech.com \
--cc=xyangxi5@gmail.com \
--cc=yangtiezhu@loongson.cn \
--cc=zhangxuezhi1@coolpad.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox