From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D28E2ECAAD1 for ; Wed, 31 Aug 2022 12:41:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231365AbiHaMl0 (ORCPT ); Wed, 31 Aug 2022 08:41:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231329AbiHaMlW (ORCPT ); Wed, 31 Aug 2022 08:41:22 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42B27A6AD5 for ; Wed, 31 Aug 2022 05:41:18 -0700 (PDT) Date: Wed, 31 Aug 2022 14:41:14 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1661949676; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=b4uXfTcXJzEovtZTYHUIWB1giQlX2EAgRixcjojyZUc=; b=LZdL38rlXuRLJh7odxvZiaog0QghoYrz6jGF0KjU2yYKL/MFXKyslMUh+d0OKuLAd2VNla 6UVXKPozdmKKRpcxqP59K7VolpFF3F/uDqvkEYsI0tzcEBC/zFCgmpUHD4gZ1+yqXBZjxK 2jGfrvK9xZLLK/D4XPk/Y8OXBaRboVZdClrSAEoPlhAUXe0OjKPxY7F0mfXsX+QMtrT5vt 256CIi0U207an6+yv7j0exucpo8IV7qVeqwKQ1+UPBOrlN3ehjYxmbCkoBsxJ8O0PUvgxk Q0nK/tNEDlqb+DXP43HIwzyFT4TR/rF2dOEk7Rn4j8u+bR95rcEnNHVqiGkvgQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1661949676; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=b4uXfTcXJzEovtZTYHUIWB1giQlX2EAgRixcjojyZUc=; b=noyoIPRmtDlSp2u5341YWxmR8O99J08P5w5SpEnjqzejIfnvXse6u+sK5pphZML3GgZj7N zLBLvVMWNB7RylCg== From: Sebastian Andrzej Siewior To: Daniel Vetter Cc: LKML , DRI Development , Daniel Vetter , Greg Kroah-Hartman , Jiri Slaby , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , Tetsuo Handa , Xuezhi Zhang , Yangxi Xiang , nick black , Petr Mladek , Andrew Morton , Luis Chamberlain , "Guilherme G. Piccoli" , Marco Elver , John Ogness , David Gow , tangmeng , Tiezhu Yang , Chris Wilson Subject: Re: [PATCH] kernel/panic: Drop unblank_screen call Message-ID: References: <20220830145004.430545-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220830145004.430545-1-daniel.vetter@ffwll.ch> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-08-30 16:50:04 [+0200], Daniel Vetter wrote: > Long story short, I have no idea why the direct call to unblank_screen > survived for so long (the infrastructure to do it properly existed for > years), nor why it wasn't removed when the console_unblank() call was > finally added. But it makes a ton more sense to finally do that than > not - it's just better encapsulation to go through the console > functions instead of doing a direct call, so let's dare. Plus it > really does not make much sense to call the only unblank > implementation there is twice, once without, and once with appropriate > locking. Yup, calling it twice is redundant. The only difference I see is that the console implementation relies on CONFIG_VT_CONSOLE while the former relied only on CONFIG_VT. There should be no console output without CONFIG_VT_CONSOLE so no need to unblank it. Acked-by: Sebastian Andrzej Siewior Sebastian