public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Xuezhi Zhang <zhangxuezhi3@gmail.com>
Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com,
	zhangxuezhi1@coolpad.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] comedi: sysfs: convert sysfs snprintf to sysfs_emit
Date: Wed, 31 Aug 2022 16:02:11 +0200	[thread overview]
Message-ID: <Yw9p47naEjsCWAJW@kroah.com> (raw)
In-Reply-To: <20220831125520.239055-1-zhangxuezhi3@gmail.com>

On Wed, Aug 31, 2022 at 08:55:20PM +0800, Xuezhi Zhang wrote:
> From: zhangxuezhi1 <zhangxuezhi1@coolpad.com>
> 
> Fix up all sysfs show entries to use sysfs_emit

This says "what", but not "why".

Please read the kernel documentation for how to write a good changelog
text.

> 
> Signed-off-by: Xuezhi Zhang <zhangxuezhi1@coolpad.com>
> ---
> v2: use a proper name for the Signed-off-by line.

Does not match the From: line :(


thanks,

greg k-h

  parent reply	other threads:[~2022-08-31 14:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-31 12:55 [PATCH v2] comedi: sysfs: convert sysfs snprintf to sysfs_emit Xuezhi Zhang
2022-08-31 12:58 ` Ian Abbott
2022-08-31 14:02 ` Greg KH [this message]
2022-09-01  1:05   ` zhangxuezhi3

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yw9p47naEjsCWAJW@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=abbotti@mev.co.uk \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zhangxuezhi1@coolpad.com \
    --cc=zhangxuezhi3@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox