From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57CA9ECAAD4 for ; Wed, 31 Aug 2022 14:19:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232060AbiHaOT0 (ORCPT ); Wed, 31 Aug 2022 10:19:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231786AbiHaOTW (ORCPT ); Wed, 31 Aug 2022 10:19:22 -0400 Received: from smtp2.axis.com (smtp2.axis.com [195.60.68.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24F1F5F84; Wed, 31 Aug 2022 07:19:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1661955561; x=1693491561; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=7Y64+ITKD3t7WxyXsYjghMjwDYMJbKCBeS7pYX8P4GQ=; b=nlv6dP767aV2n/y08ZV5WUrqMvidwVB2x+LqhgfsNUG73C95qZ3irOqT Gp7S7SAKhsh21yvV4oLfh8X0pVsGZD3jwbuxPCyMfIDPawzK7YrkJUkbq KlE1obt+PfGuwzGDGomKLAd0dWxzmVUIMgEQ/Lvk05+Pzs9bojNeqQ9jG hL/aBqcLq6+uNJl1MV6Lwu6oAEb2r1/xcnahUfcwa/l1d9z/mnLSsCyUC UiyFIqXhFRfP12ZTavcO/6uovXPqWvihzuK1A2YS2rb6IWDl+JptY3ldD 1e8dXchcPvsIvBDnDo4UuoPhFzkO6wJp048hgCp9GS1JzBxx9+EztFrhY g==; Date: Wed, 31 Aug 2022 16:19:19 +0200 From: Vincent Whitchurch To: Andy Shevchenko CC: Jonathan Cameron , kernel , Lars-Peter Clausen , linux-iio , Linux Kernel Mailing List Subject: Re: [PATCH v2 1/5] iio: adc: mcp320x: use callbacks for RX conversion Message-ID: References: <20220831100506.3368103-1-vincent.whitchurch@axis.com> <20220831100506.3368103-2-vincent.whitchurch@axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 31, 2022 at 02:40:49PM +0200, Andy Shevchenko wrote: > On Wed, Aug 31, 2022 at 1:05 PM Vincent Whitchurch > wrote: > > Replace the device_index switch with callbacks from the chip_info > > structure, so that the latter has all the information needed to handle > > the variants. > > Below are for the further patches, as I see the original code has the > same disadvantages. Right, these comments are in the original code that is either being just being moved or that even just happens to be in the context of the diff. Just to clarify, do you mean by "further patches" that you expect patches to fix these comments to be added to this series which adds triggered buffer support?