From: Greg KH <gregkh@linuxfoundation.org>
To: Tuo Cao <91tuocao@gmail.com>
Cc: alcooperx@gmail.com, bcm-kernel-feedback-list@broadcom.com,
jirislaby@kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND] serial: 8250_bcm7271: move spin_lock_irqsave to spin_lock in interrupt handler
Date: Mon, 22 Aug 2022 16:25:15 +0200 [thread overview]
Message-ID: <YwORy3QMbRUSlBZE@kroah.com> (raw)
In-Reply-To: <20220822141110.17199-1-91tuocao@gmail.com>
On Mon, Aug 22, 2022 at 10:11:10PM +0800, Tuo Cao wrote:
> it is unnecessary to call spin_lock_irqsave in a interrupt handler.
Yes, but it is safer to do so, right?
Why is this change needed?
Did you test it on real hardware to verify it works?
We need a lot more information in the changelog text before being able
to accept this.
thanks,
greg k-h
next prev parent reply other threads:[~2022-08-22 14:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 14:11 [RESEND] serial: 8250_bcm7271: move spin_lock_irqsave to spin_lock in interrupt handler Tuo Cao
2022-08-22 14:25 ` Greg KH [this message]
2022-08-27 9:42 ` tuo cao
2022-08-30 11:35 ` Greg KH
2022-09-04 8:48 ` tuo cao
2022-09-04 13:10 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwORy3QMbRUSlBZE@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=91tuocao@gmail.com \
--cc=alcooperx@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox