From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Christian Brauner <brauner@kernel.org>
Cc: "Todd Kjos" <tkjos@android.com>,
linux-kernel@vger.kernel.org, "Al Viro" <viro@zeniv.linux.org.uk>,
"Arve Hjønnevåg" <arve@android.com>,
"Martijn Coenen" <maco@android.com>,
"Joel Fernandes" <joel@joelfernandes.org>,
"Carlos Llamas" <cmllamas@google.com>,
"Suren Baghdasaryan" <surenb@google.com>,
"Kees Cook" <keescook@chromium.org>,
"Dongliang Mu" <mudongliangabcd@gmail.com>,
syzkaller <syzkaller@googlegroups.com>
Subject: Re: [PATCH v2] binderfs: rework superblock destruction
Date: Tue, 23 Aug 2022 12:45:26 +0200 [thread overview]
Message-ID: <YwSvxrA6efdt9Gix@kroah.com> (raw)
In-Reply-To: <20220823095339.853371-1-brauner@kernel.org>
On Tue, Aug 23, 2022 at 11:53:39AM +0200, Christian Brauner wrote:
> From: Al Viro <viro@zeniv.linux.org.uk>
>
> So far we relied on
> .put_super = binderfs_put_super()
> to destroy info we stashed in sb->s_fs_info. This gave us the required ordering
> between ->evict_inode() and sb->s_fs_info destruction.
>
> But the current implementation of binderfs_fill_super() has a memory leak in
> the rare circumstance that d_make_root() fails because ->put_super() is only
> called when sb->s_root is initialized. Fix this by removing ->put_super() and
> simply do all that work in binderfs_kill_super().
>
> Reported-by: Dongliang Mu <mudongliangabcd@gmail.com>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> Signed-off-by: Christian Brauner (Microsoft) <brauner@kernel.org>
> ---
> drivers/android/binderfs.c | 30 +++++++++++++++++-------------
> 1 file changed, 17 insertions(+), 13 deletions(-)
What changed from v1?
next prev parent reply other threads:[~2022-08-23 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 9:53 [PATCH v2] binderfs: rework superblock destruction Christian Brauner
2022-08-23 10:45 ` Greg Kroah-Hartman [this message]
2022-08-23 10:57 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwSvxrA6efdt9Gix@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arve@android.com \
--cc=brauner@kernel.org \
--cc=cmllamas@google.com \
--cc=joel@joelfernandes.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=mudongliangabcd@gmail.com \
--cc=surenb@google.com \
--cc=syzkaller@googlegroups.com \
--cc=tkjos@android.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox