[RFC Patch net-next v2] net: dsa: microchip: lan937x: enable interrupt for internal phy link detection

Arun Ramadoss
2022-08-22T09:22:23Z

This patch enables the interrupts for internal phy link detection for
LAN937x. The interrupt enable bits are active low. It first enables port
interrupt and then port phy interrupt. Also patch register the irq
thread and in the ISR routine it clears the POR_READY_STS bit.
POR_READY_STS bit is write one clear bit and all other bit in the
register are read only. Since phy interrupts are handled by the lan937x
phy layer, switch interrupt routine does not read the phy layer
interrupts.

Signed-off-by: Arun Ramadoss <arun.ramadoss@microchip.com>
---
Changes in RFC v2
- fixed the compilation issue

drivers/net/dsa/microchip/ksz_common.h | 1 +
drivers/net/dsa/microchip/ksz_spi.c | 2 +
drivers/net/dsa/microchip/lan937x_main.c | 64 ++++++++++++++++++++++++
drivers/net/dsa/microchip/lan937x_reg.h | 10 ++++
4 files changed, 77 insertions(+)

diff --git a/drivers/net/dsa/microchip/ksz_common.h b/drivers/net/dsa/microchip/ksz_common.h
index 764ada3a0f42..a84488e6fab6 100644
--- a/drivers/net/dsa/microchip/ksz_common.h
+++ b/drivers/net/dsa/microchip/ksz_common.h
@@ -98,6 +98,7 @@ struct ksz_device {
struct regmap *regmap[3];

void *priv;
+ int irq;

struct gpio_desc *reset_gpio; /* Optional reset GPIO */

diff --git a/drivers/net/dsa/microchip/ksz_spi.c b/drivers/net/dsa/microchip/ksz_spi.c
index 05bd089795f8..7ba897b6f950 100644
--- a/drivers/net/dsa/microchip/ksz_spi.c
+++ b/drivers/net/dsa/microchip/ksz_spi.c
@@ -85,6 +85,8 @@ static int ksz_spi_probe(struct spi_device *spi)
if (ret)
return ret;

+ dev->irq = spi->irq;
+
ret = ksz_switch_register(dev);

/* Main DSA driver may not be started yet. */
diff --git a/drivers/net/dsa/microchip/lan937x_main.c b/drivers/net/dsa/microchip/lan937x_main.c
index daedd2bf20c1..ca786e5edf2c 100644
--- a/drivers/net/dsa/microchip/lan937x_main.c
+++ b/drivers/net/dsa/microchip/lan937x_main.c
@@ -10,6 +10,7 @@
#include <linux/of_mdio.h>
#include <linux/if_bridge.h>
#include <linux/if_vlan.h>
+#include <linux/irq.h>
#include <linux/math.h>
#include <net/dsa.h>
#include <net/switchdev.h>
@@ -23,6 +24,11 @@ static int lan937x_cfg(struct ksz_device *dev, u32 addr, u8 bits, bool set)
return regmap_update_bits(dev->regmap[0], addr, bits, set ? bits : 0);
}

+static int lan937x_cfg32(struct ksz_device *dev, u32 addr, u32 bits, bool set)
+{
+ return regmap_update_bits(dev->regmap[2], addr, bits, set ? bits : 0);
+}
+
static int lan937x_port_cfg(struct ksz_device *dev, int port, int offset,
u8 bits, bool set)
{
@@ -285,6 +291,16 @@ void lan937x_config_cpu_port(struct dsa_switch *ds)

dsa_switch_for_each_user_port(dp, ds) {
ksz_port_stp_state_set(ds, dp->index, BR_STATE_DISABLED);
+
+ if (dev->info->internal_phy[dp->index]) {
+ /* Enable PORT Interrupt - active low */
+ lan937x_cfg32(dev, REG_SW_PORT_INT_MASK__4,
+ BIT(dp->index), false);
+
+ /* Enable PORT_PHY_INT interrupt - active low */
+ lan937x_port_cfg(dev, dp->index, REG_PORT_INT_MASK,
+ PORT_PHY_INT, false);
+ }
}
}

@@ -383,6 +399,50 @@ void lan937x_setup_rgmii_delay(struct ksz_device *dev, int port)
}
}

+static irqreturn_t lan937x_switch_irq_thread(int irq, void *dev_id)
+{
+ struct ksz_device *dev = dev_id;
+ irqreturn_t result = IRQ_NONE;
+ u32 data;
+ int ret;
+
+ /* Read global interrupt status register */
+ ret = ksz_read32(dev, REG_SW_INT_STATUS__4, &data);
+ if (ret)
+ return result;
+
+ if (data & POR_READY_INT) {
+ ret = ksz_write32(dev, REG_SW_INT_STATUS__4, POR_READY_INT);
+ if (ret)
+ return result;
+ }
+
+ return result;
+}
+
+static int lan937x_register_interrupt(struct ksz_device *dev)
+{
+ int ret;
+
+ if (dev->irq > 0) {
+ unsigned long irqflags =
+ irqd_get_trigger_type(irq_get_irq_data(dev->irq));
+
+ irqflags |= (IRQF_ONESHOT | IRQF_SHARED);
+
+ ret = devm_request_threaded_irq(dev->dev, dev->irq, NULL,
+ lan937x_switch_irq_thread,
+ irqflags, dev_name(dev->dev),
+ dev);
+ if (ret) {
+ dev_err(dev->dev, "failed to request IRQ.\n");
+ return ret;
+ }
+ }
+
+ return 0;
+}
+
int lan937x_setup(struct dsa_switch *ds)
{
struct ksz_device *dev = ds->priv;
@@ -423,6 +483,10 @@ int lan937x_setup(struct dsa_switch *ds)
lan937x_cfg(dev, REG_SW_GLOBAL_OUTPUT_CTRL__1,
(SW_CLK125_ENB | SW_CLK25_ENB), true);

+ ret = lan937x_register_interrupt(dev);
+ if (ret)
+ return ret;
+
return 0;
}

diff --git a/drivers/net/dsa/microchip/lan937x_reg.h b/drivers/net/dsa/microchip/lan937x_reg.h
index ba4adaddb3ec..a4b17fc722d2 100644
--- a/drivers/net/dsa/microchip/lan937x_reg.h
+++ b/drivers/net/dsa/microchip/lan937x_reg.h
@@ -118,6 +118,16 @@
/* Port Registers */

/* 0 - Operation */
+#define REG_PORT_INT_STATUS 0x001B
+#define REG_PORT_INT_MASK 0x001F
+
+#define PORT_TAS_INT BIT(5)
+#define PORT_QCI_INT BIT(4)
+#define PORT_SGMII_INT BIT(3)
+#define PORT_PTP_INT BIT(2)
+#define PORT_PHY_INT BIT(1)
+#define PORT_ACL_INT BIT(0)
+
#define REG_PORT_CTRL_0 0x0020

#define PORT_MAC_LOOPBACK BIT(7)
--
2.36.1