* [PATCH v3 linux-next] soundwire: intel: Remove unnecessary TODO
@ 2022-08-17 7:48 Khalid Masum
2022-08-23 16:56 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Khalid Masum @ 2022-08-17 7:48 UTC (permalink / raw)
To: Pierre-Louis Bossart, alsa-devel, linux-kernel,
linux-kernel-mentees
Cc: Vinod Koul, Bard Liao, Sanyog Kale, Khalid Masum
The capabilities enabled for multi-link are required as part of the
programming sequences, even when a stream uses a single link we still
use the syncArm/syncGo sequences. Therefore the TODO is no longer
necessary.
Suggested-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Khalid Masum <khalid.masum.92@gmail.com>
---
Previous discussions:
- v2 Link: https://lore.kernel.org/lkml/20220816175954.5259-1-khalid.masum.92@gmail.com/
- v1 Link: https://lore.kernel.org/lkml/20220814080416.7531-1-khalid.masum.92@gmail.com/
Changes since v2:
- Update commit title.
Changes since v1:
- Remove the todo, leave rest of the code as is.
- Update commit message.
drivers/soundwire/bus.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index 8d4000664fa3..18158825a6d8 100644
--- a/drivers/soundwire/bus.c
+++ b/drivers/soundwire/bus.c
@@ -75,7 +75,6 @@ int sdw_bus_master_add(struct sdw_bus *bus, struct device *parent,
/*
* Initialize multi_link flag
- * TODO: populate this flag by reading property from FW node
*/
bus->multi_link = false;
if (bus->ops->read_prop) {
--
2.37.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3 linux-next] soundwire: intel: Remove unnecessary TODO
2022-08-17 7:48 [PATCH v3 linux-next] soundwire: intel: Remove unnecessary TODO Khalid Masum
@ 2022-08-23 16:56 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2022-08-23 16:56 UTC (permalink / raw)
To: Khalid Masum
Cc: Pierre-Louis Bossart, alsa-devel, linux-kernel,
linux-kernel-mentees, Bard Liao, Sanyog Kale
On 17-08-22, 13:48, Khalid Masum wrote:
> The capabilities enabled for multi-link are required as part of the
> programming sequences, even when a stream uses a single link we still
> use the syncArm/syncGo sequences. Therefore the TODO is no longer
> necessary.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-23 18:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-17 7:48 [PATCH v3 linux-next] soundwire: intel: Remove unnecessary TODO Khalid Masum
2022-08-23 16:56 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox