From: Matthias Kaehlcke <mka@chromium.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-arm-msm@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>,
Douglas Anderson <dianders@chromium.org>,
Krishna Kurapati <quic_kriskura@quicinc.com>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH 1/2] clk: qcom: gcc-sc7180: Keep USB GDSC power domain on when USB wakeup is enabled
Date: Tue, 23 Aug 2022 12:05:31 -0700 [thread overview]
Message-ID: <YwUk+ymRUdwzBTnX@google.com> (raw)
In-Reply-To: <20220822235207.A4D8EC433D6@smtp.kernel.org>
Hi Stephen,
On Mon, Aug 22, 2022 at 04:52:05PM -0700, Stephen Boyd wrote:
> Quoting Matthias Kaehlcke (2022-08-22 11:53:10)
> > Set GENPD_FLAG_ACTIVE_WAKEUP for the USB GDSC power domain of SC7180.
>
> Why? Does it fix something? Please add details to the commit text so we
> know how urgent of a patch it is and why it is important.
Without it USB is broken after resume when the PHYs remain enabled
during suspend.
Johan just sent a patch [1] that always disables the PHYs (again)
during system suspend, with that this series shouldn't be needed.
It is possible that in the future we add a mechanism to keep the
PHYs on depending on some config option (quick, kconfig, ...). If
that happens we'll have to revisit this series, for now it
shouldn't be needed assuming Johan's patch gets landed.
[1] https://patchwork.kernel.org/project/linux-usb/patch/20220823124047.14634-1-johan+linaro@kernel.org/
prev parent reply other threads:[~2022-08-23 19:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 18:53 [PATCH 1/2] clk: qcom: gcc-sc7180: Keep USB GDSC power domain on when USB wakeup is enabled Matthias Kaehlcke
2022-08-22 18:53 ` [PATCH 2/2] clk: qcom: gcc-sc7280: Keep USB GDSC power domains " Matthias Kaehlcke
2022-08-23 11:16 ` Johan Hovold
2022-08-23 16:42 ` Matthias Kaehlcke
2022-08-24 8:47 ` Johan Hovold
2022-08-25 22:16 ` Matthias Kaehlcke
2022-08-26 7:12 ` Johan Hovold
2022-08-26 13:05 ` Matthias Kaehlcke
2022-08-26 13:12 ` Johan Hovold
2022-08-26 13:19 ` Matthias Kaehlcke
2022-08-26 13:24 ` Matthias Kaehlcke
2022-08-26 13:26 ` Johan Hovold
2022-08-26 13:33 ` Matthias Kaehlcke
2022-08-22 23:52 ` [PATCH 1/2] clk: qcom: gcc-sc7180: Keep USB GDSC power domain " Stephen Boyd
2022-08-23 19:05 ` Matthias Kaehlcke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwUk+ymRUdwzBTnX@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_kriskura@quicinc.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox