Re: [PATCH v3 1/5] x86/microcode/intel: Check against CPU signature before saving microcode

Ashok Raj
2022-08-17T10:46:20Z

Hi Ingo

On Wed, Aug 17, 2022 at 09:43:07AM +0200, Ingo Molnar wrote:
>
> * Ashok Raj <ashok.raj@intel.com> wrote:
>
> > Cc: stable@vger.kernel.org
>
> Not sure the series justifies stable - there's like a ton of things that
> could go wrong with a series like this & we want to have some serious
> testing first.

Its my bad I got lazy and put this patch in the series. This is a *bug* in
existing code, and completely unrelated. I must have submitted it
just by itself.

Boris, let me know if you want me to resubmit and I'll do this by itself.

>
> > list_for_each_entry_safe(iter, tmp, &microcode_cache, plist) {
> > mc_saved_hdr = (struct microcode_header_intel *)iter->data;
> > - sig = mc_saved_hdr->sig;
> > - pf = mc_saved_hdr->pf;
> >
> > - if (find_matching_signature(data, sig, pf)) {
> > + sig = uci->cpu_sig.sig;
> > + pf = uci->cpu_sig.pf;
> > +
> > + /*
> > + * Compare the current CPUs signature with the ones in the
>
> s/CPUs
> /CPU's

Thanks, will update.