Re: [PATCH v3 1/5] x86/microcode/intel: Check against CPU signature before saving microcode

Ingo Molnar
2022-08-17T07:43:24Z

* Ashok Raj <ashok.raj@intel.com> wrote:

> Cc: stable@vger.kernel.org

Not sure the series justifies stable - there's like a ton of things that
could go wrong with a series like this & we want to have some serious
testing first.

> list_for_each_entry_safe(iter, tmp, &microcode_cache, plist) {
> mc_saved_hdr = (struct microcode_header_intel *)iter->data;
> - sig = mc_saved_hdr->sig;
> - pf = mc_saved_hdr->pf;
>
> - if (find_matching_signature(data, sig, pf)) {
> + sig = uci->cpu_sig.sig;
> + pf = uci->cpu_sig.pf;
> +
> + /*
> + * Compare the current CPUs signature with the ones in the

s/CPUs
/CPU's

Thanks,

Ingo